Skip to content

Commit

Permalink
[EuiDataGrid] Cell actions redesign (#7343)
Browse files Browse the repository at this point in the history
  • Loading branch information
cee-chen authored Nov 20, 2023
1 parent ada8592 commit 7430ef5
Show file tree
Hide file tree
Showing 26 changed files with 818 additions and 889 deletions.
6 changes: 6 additions & 0 deletions changelogs/upcoming/7343.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
- Updated `EuiDataGrid` cell actions to display above cells instead of within them, to avoid content clipping issues
- Updated `EuiDataGrid` cell expansion popovers to sit on top of cells instead of below/next to them

**Bug fixes**

- Fixed incorrect `EuiPopover` positioning calculations when `hasArrow` was set to false
1 change: 1 addition & 0 deletions cypress/support/component-index.html
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@
<meta http-equiv="X-UA-Compatible" content="IE=edge">
<meta name="viewport" content="width=device-width,initial-scale=1.0">
<meta name="css-styles">
<link rel="stylesheet" href="https://fonts.googleapis.com/css2?family=Inter:wght@400;700&display=swap">
<title>Components App</title>
</head>

Expand Down
13 changes: 0 additions & 13 deletions src/components/combo_box/combo_box.spec.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -20,19 +20,6 @@ import {
type EuiComboBoxOptionOption,
} from './index';

// CI doesn't have access to the Inter font, so we need to manually include it
// for truncation font calculations to work correctly
before(() => {
const linkElem = document.createElement('link');
linkElem.setAttribute('rel', 'stylesheet');
linkElem.setAttribute(
'href',
'https://fonts.googleapis.com/css2?family=Inter:wght@400;700&display=swap'
);
document.head.appendChild(linkElem);
cy.wait(1000); // Wait a second to give the font time to load/swap in
});

describe('EuiComboBox', () => {
describe('focus management', () => {
it('keeps focus on the input box when clicking a disabled item', () => {
Expand Down
Loading

0 comments on commit 7430ef5

Please sign in to comment.