another pass

elastic · Mar 2, 2020 · 72e5332 · 72e5332
1 parent cc9ee52
commit 72e5332
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 2 deletions.
diff --git a/src/components/nav_drawer/nav_drawer.tsx b/src/components/nav_drawer/nav_drawer.tsx
@@ -19,6 +19,7 @@ const MENU_ELEMENT_ID = 'navDrawerMenu';
 export type FlyoutLink =
   EuiListGroupItemProps
   & {
+    "data-name"?: ReactNode,
     flyoutMenu?: {
       title: string,
       listItems: EuiListGroupProps["listItems"]
@@ -342,7 +343,7 @@ export class EuiNavDrawer extends Component<EuiNavDrawerProps, EuiNavDrawerState
               sideNavLockAriaLabel,
               sideNavLockExpanded,
               sideNavLockCollapsed,
-            ]) => (
+            ]: string[]) => (
               <EuiListGroupItem
                 buttonRef={node => (this.expandButtonRef = node)}
                 label={this.state.isCollapsed ? sideNavExpand : sideNavCollapse}

diff --git a/src/components/nav_drawer/nav_drawer_group.tsx b/src/components/nav_drawer/nav_drawer_group.tsx
@@ -5,6 +5,7 @@ import { toInitials } from '../../services';
 import { CommonProps } from '../common';
 import { EuiListGroup } from '../list_group';
 import { FlyoutLink } from './nav_drawer';
+import { EuiListGroupProps } from '../list_group';
 
 export const ATTR_SELECTOR = 'data-name';
 
@@ -16,12 +17,14 @@ export interface EuiNavDrawerGroupProps
      * While not normally required, it is required to pass a function for handling
      * of the flyout menu button click
      */
-    flyoutMenuButtonClick: (items: Array<FlyoutLink>, title: string, item: FlyoutLink) => MouseEventHandler<HTMLButtonElement>,
+    flyoutMenuButtonClick?: (items: Array<FlyoutLink>, title: string, item: FlyoutLink) => MouseEventHandler<HTMLButtonElement>,
     /**
      * Passthrough function to be called when the flyout is closing
      * See ./nav_drawer.js
      */
     onClose: () => void,
+    ariaLabelledby?: string;
+    wrapText: EuiListGroupProps["wrapText"],
   }
 
 export const EuiNavDrawerGroup: FunctionComponent<EuiNavDrawerGroupProps> = ({

diff --git a/src/components/title/title.tsx b/src/components/title/title.tsx
@@ -26,6 +26,7 @@ export type EuiTitleProps = CommonProps & {
   size?: EuiTitleSize;
   textTransform?: EuiTitleTextTransform;
   id?: string;
+  tabIndex?: string;
 };
 
 export const EuiTitle: FunctionComponent<EuiTitleProps> = ({