Add more EuiContextMenuItemProps typings (#1006)

* Add disabled and onClick options to EuiContextMenuItemProps * extend common props * Add more props, add HTMLElement as acceptable for icon.
elastic · Jul 13, 2018 · 72b77cb · 72b77cb
1 parent d07d71d
commit 72b77cb
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 2 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,5 +1,6 @@
 ## [`master`](https://github.com/elastic/eui/tree/master)
 
+- Add more typings to `EuiContextMenuItemProps` ([#1006](https://github.com/elastic/eui/pull/1006))
 - Make some proprties of `EuiFlyout` optional ([#1003](https://github.com/elastic/eui/pull/1003))
 - Add typings for `EuiFlyout`, `EuiFlyoutBody`, `EuiFlyoutHeader`, and `EuiFlyoutFooter` ([#1001](https://github.com/elastic/eui/pull/1001))
 - Gave `EuiFlyout` close button a data-test-subj ([#1000](https://github.com/elastic/eui/pull/1000))

diff --git a/src/components/context_menu/index.d.ts b/src/components/context_menu/index.d.ts
@@ -53,12 +53,22 @@ declare module '@elastic/eui' {
    * @see './context_menu_item.js`
    */
 
-  export type EuiContextMenuItemIcon = ReactElement<any> | string;
+  export type EuiContextMenuItemIcon = ReactElement<any> | string | HTMLElement;
 
-  export interface EuiContextMenuItemProps {
+  export interface EuiContextMenuItemProps extends CommonProps {
     icon?: EuiContextMenuItemIcon;
     hasPanel?: boolean;
+    disabled?: boolean;
+    onClick?: () => void;
     buttonRef?: RefCallback<HTMLButtonElement>;
+    hasPanel?: boolean;
+    toolTipContent?: ReactNode;
+    toolTipTitle?: ReactNode;
+    toolTipPosition?: string;
+    href?: string;
+    target?: string;
+    rel?: string;
+    children?: ReactNode;
   }
 
   export const EuiContextMenuItem: SFC<