Skip to content

Commit

Permalink
Memoize basic skeleton component styles
Browse files Browse the repository at this point in the history
  • Loading branch information
cee-chen committed Mar 7, 2024
1 parent 5cc4ce8 commit 67adfe0
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 9 deletions.
5 changes: 2 additions & 3 deletions src/components/skeleton/skeleton_circle.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -9,8 +9,8 @@
import React, { FunctionComponent, HTMLAttributes } from 'react';
import classNames from 'classnames';

import { useEuiMemoizedStyles } from '../../services';
import { CommonProps } from '../common';
import { useEuiTheme } from '../../services';

import { EuiSkeletonLoading, _EuiSkeletonAriaProps } from './skeleton_loading';
import { euiSkeletonCircleStyles } from './skeleton_circle.styles';
Expand All @@ -36,8 +36,7 @@ export const EuiSkeletonCircle: FunctionComponent<EuiSkeletonCircleProps> = ({
children,
...rest
}) => {
const euiTheme = useEuiTheme();
const styles = euiSkeletonCircleStyles(euiTheme);
const styles = useEuiMemoizedStyles(euiSkeletonCircleStyles);
const cssStyles = [styles.euiSkeletonCircle, styles[size]];

return (
Expand Down
5 changes: 2 additions & 3 deletions src/components/skeleton/skeleton_rectangle.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -9,8 +9,8 @@
import React, { FunctionComponent, HTMLAttributes } from 'react';
import classNames from 'classnames';

import { useEuiMemoizedStyles } from '../../services';
import { CommonProps } from '../common';
import { useEuiTheme } from '../../services';
import { logicalStyles } from '../../global_styling';

import { EuiSkeletonLoading, _EuiSkeletonAriaProps } from './skeleton_loading';
Expand Down Expand Up @@ -44,8 +44,7 @@ export const EuiSkeletonRectangle: FunctionComponent<
children,
...rest
}) => {
const euiTheme = useEuiTheme();
const styles = euiSkeletonRectangleStyles(euiTheme);
const styles = useEuiMemoizedStyles(euiSkeletonRectangleStyles);
const cssStyles = [styles.euiSkeletonRectangle, styles[borderRadius]];

return (
Expand Down
5 changes: 2 additions & 3 deletions src/components/skeleton/skeleton_title.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -9,8 +9,8 @@
import React, { FunctionComponent, HTMLAttributes } from 'react';
import classNames from 'classnames';

import { useEuiMemoizedStyles } from '../../services';
import { CommonProps } from '../common';
import { useEuiTheme } from '../../services';
import { EuiTitleSize } from '../title';

import { EuiSkeletonLoading, _EuiSkeletonAriaProps } from './skeleton_loading';
Expand All @@ -37,8 +37,7 @@ export const EuiSkeletonTitle: FunctionComponent<EuiSkeletonTitleProps> = ({
children,
...rest
}) => {
const euiTheme = useEuiTheme();
const styles = euiSkeletonTitleStyles(euiTheme);
const styles = useEuiMemoizedStyles(euiSkeletonTitleStyles);
const cssStyles = [styles.euiSkeletonTitle, styles[size]];

return (
Expand Down

0 comments on commit 67adfe0

Please sign in to comment.