Skip to content

Commit

Permalink
fix badge examples, fix combo box usage of badge
Browse files Browse the repository at this point in the history
  • Loading branch information
snide committed May 4, 2018
1 parent 10c5b3a commit 505b5ad
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 0 deletions.
2 changes: 2 additions & 0 deletions src-docs/src/views/badge/badge_button.js
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ export default () => (
<EuiBadge
color="#333"
onClick={() => window.alert('Badge clicked')}
onClickAriaLabel="Example of onclick event for the button"
>
onClick on badge itself
</EuiBadge>
Expand All @@ -18,6 +19,7 @@ export default () => (
iconSide="right"
color="#333"
iconOnClick={() => window.alert('Icon inside badge clicked')}
iconOnClickAriaLabel="Example of onclick event for icon within the button"
>
onClick on icon within badge
</EuiBadge>
Expand Down
1 change: 1 addition & 0 deletions src/components/combo_box/combo_box_input/combo_box_pill.js
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,7 @@ export class EuiComboBoxPill extends Component {
className={classes}
title={children}
iconOnClick={this.onCloseButtonClick}
iconOnClickAriaLabel={`Remove ${children} from selection in this group`}
iconType="cross"
iconSide="right"
color={color}
Expand Down

0 comments on commit 505b5ad

Please sign in to comment.