Clean up/remove various responsive Sass files/modifiers

+ remove `.euiTableRowCell--isMobileHeader` - isn't used anywhere that I can tell 🤷
elastic · Mar 26, 2024 · 4bf8c22 · 4bf8c22
1 parent a197141
commit 4bf8c22
Show file tree

Hide file tree

Showing 9 changed files with 6 additions and 16 deletions.
diff --git a/src/components/basic_table/__snapshots__/basic_table.test.tsx.snap b/src/components/basic_table/__snapshots__/basic_table.test.tsx.snap
@@ -8,7 +8,7 @@ exports[`EuiBasicTable renders (bare-bones) 1`] = `
 >
   <div>
     <table
-      class="euiTable euiTable--responsive emotion-euiTable-fixed-uncompressed-desktop"
+      class="euiTable emotion-euiTable-fixed-uncompressed-desktop"
       id="__table_generated-id"
       tabindex="-1"
     >
@@ -122,7 +122,7 @@ exports[`EuiBasicTable renders (kitchen sink) with pagination, selection, sortin
 >
   <div>
     <table
-      class="euiTable euiTable--responsive emotion-euiTable-fixed-uncompressed-desktop"
+      class="euiTable emotion-euiTable-fixed-uncompressed-desktop"
       id="__table_generated-id"
       tabindex="-1"
     >

diff --git a/src/components/basic_table/__snapshots__/in_memory_table.test.tsx.snap b/src/components/basic_table/__snapshots__/in_memory_table.test.tsx.snap
@@ -104,7 +104,7 @@ exports[`EuiInMemoryTable empty array 1`] = `
 >
   <div>
     <table
-      class="euiTable euiTable--responsive emotion-euiTable-fixed-uncompressed-desktop"
+      class="euiTable emotion-euiTable-fixed-uncompressed-desktop"
       id="__table_generated-id"
       tabindex="-1"
     >
@@ -199,7 +199,7 @@ exports[`EuiInMemoryTable with items 1`] = `
 >
   <div>
     <table
-      class="euiTable euiTable--responsive emotion-euiTable-fixed-uncompressed-desktop"
+      class="euiTable emotion-euiTable-fixed-uncompressed-desktop"
       id="__table_generated-id"
       tabindex="-1"
     >

diff --git a/src/components/table/__snapshots__/table.test.tsx.snap b/src/components/table/__snapshots__/table.test.tsx.snap
@@ -3,7 +3,7 @@
 exports[`renders EuiTable 1`] = `
 <table
   aria-label="aria-label"
-  class="euiTable testClass1 testClass2 euiTable--responsive emotion-euiTable-fixed-uncompressed-desktop-euiTestCss"
+  class="euiTable testClass1 testClass2 emotion-euiTable-fixed-uncompressed-desktop-euiTestCss"
   data-test-subj="test subject string"
   tabindex="-1"
 >

diff --git a/src/components/table/_index.scss b/src/components/table/_index.scss
@@ -2,6 +2,3 @@
 @import 'mixins';
 
 @import 'table';
-@import 'responsive';
-
-@import 'mobile/index';
diff --git a/src/components/table/_responsive.scss b/src/components/table/_responsive.scss
diff --git a/src/components/table/_table.scss b/src/components/table/_table.scss
@@ -71,10 +71,6 @@
   &--baseline {
     vertical-align: baseline;
   }
-
-  &.euiTableRowCell--isMobileHeader {
-    display: none; // Hide if not mobile breakpoint
-  }
 }
 
 .euiTableRowCellCheckbox {

diff --git a/src/components/table/mobile/_index.scss b/src/components/table/mobile/_index.scss
diff --git a/src/components/table/mobile/_mobile.scss b/src/components/table/mobile/_mobile.scss
diff --git a/src/components/table/table.tsx b/src/components/table/table.tsx
@@ -36,9 +36,7 @@ export const EuiTable: FunctionComponent<EuiTableProps> = ({
   // TODO: Make the table responsive breakpoint customizable via prop
   const isResponsive = useIsWithinMaxBreakpoint('s') && responsive;
 
-  const classes = classNames('euiTable', className, {
-    'euiTable--responsive': responsive,
-  });
+  const classes = classNames('euiTable', className);
 
   const styles = useEuiMemoizedStyles(euiTableStyles);
   const cssStyles = [