[EuiBasicTable][tech debt] Clean up now-unnecessary conditional mobil…

…e select all checkbox logic - Since the mobile header no longer renders or non-mobile views, we don't need this conditional logic anymore wooo
elastic · Jun 6, 2024 · 39e6cb8 · 39e6cb8
1 parent cfbf8d5
commit 39e6cb8
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 6 deletions.
diff --git a/packages/eui/src/components/basic_table/__snapshots__/basic_table.test.tsx.snap b/packages/eui/src/components/basic_table/__snapshots__/basic_table.test.tsx.snap
@@ -151,7 +151,7 @@ exports[`EuiBasicTable renders (kitchen sink) with pagination, selection, sortin
                 aria-label="Select all rows"
                 class="euiCheckbox__input"
                 data-test-subj="checkboxSelectAll"
-                id="_selection_column-checkbox_generated-id_desktop"
+                id="_selection_column-checkbox_generated-id"
                 title="Select all rows"
                 type="checkbox"
               />

diff --git a/packages/eui/src/components/basic_table/__snapshots__/in_memory_table.test.tsx.snap b/packages/eui/src/components/basic_table/__snapshots__/in_memory_table.test.tsx.snap
@@ -10,7 +10,8 @@ exports[`EuiInMemoryTable behavior mobile header 1`] = `
     <input
       aria-label="Select all rows"
       class="euiCheckbox__input"
-      id="_selection_column-checkbox_generated-id_mobile"
+      data-test-subj="checkboxSelectAll"
+      id="_selection_column-checkbox_generated-id"
       title="Select all rows"
       type="checkbox"
     />
@@ -19,7 +20,7 @@ exports[`EuiInMemoryTable behavior mobile header 1`] = `
     />
     <label
       class="euiCheckbox__label"
-      for="_selection_column-checkbox_generated-id_mobile"
+      for="_selection_column-checkbox_generated-id"
     >
       Select all rows
     </label>

diff --git a/packages/eui/src/components/basic_table/basic_table.tsx b/packages/eui/src/components/basic_table/basic_table.tsx
@@ -711,13 +711,12 @@ export class EuiBasicTable<T extends object = any> extends Component<
       >
         {([selectAllRows, deselectRows]: string[]) => (
           <EuiCheckbox
-            id={this.selectAllIdGenerator(isMobile ? 'mobile' : 'desktop')}
+            id={this.selectAllIdGenerator()}
             checked={checked}
             indeterminate={indeterminate}
             disabled={disabled}
             onChange={onChange}
-            // Only add data-test-subj to one of the checkboxes
-            data-test-subj={isMobile ? undefined : 'checkboxSelectAll'}
+            data-test-subj="checkboxSelectAll"
             aria-label={checked || indeterminate ? deselectRows : selectAllRows}
             title={checked || indeterminate ? deselectRows : selectAllRows}
             label={isMobile ? selectAllRows : null}