-
Notifications
You must be signed in to change notification settings - Fork 844
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[Emotion] Convert EuiProgress (#5986)
* Add basic euiProgress styles * Convert euiProgress--native and euiProgress--indeterminate to Emotion + move Amsterdam override CSS into Emotion + add prefers-reduced-motion accommodation * Convert size modifiers to Emotion * Convert position modifiers to Emotion + pass native/determinate JS var to Emotion styles to conditionally render native vs non native CSS + remove unnecessary `::moz-progress-bar` selector - that affects the value color, not the background color, and should not have been added * Convert color modifiers to Emotion - create DRY helpers for repeating native vs indeterminate selectors - start valueText styles while here - remove unnecessary isNamedColor fn/typing in favor of single var - fix playground control * Add tests for JS styles logic * Convert euiProgress__data and other children to Emotion + simplify CSS: apply text styling to parent __data wrapper as opposed to both children (truncation still needs to individually be on both children) - simplify CSS: remove need for nested `+` selector by: - converting `padding-left` to `gap` - always setting text alignment to right (removes need for margin-left: auto) - always setting flex grow/flex shrink CSS (same visual effect as before) * Update unit tests/snapshots * Remove all EuiProgress Sass files and variables * Changelog * [PR feedback] Apply text contrast function to custom colors
- Loading branch information
Constance
authored
Jun 23, 2022
1 parent
2298516
commit 21a24c3
Showing
16 changed files
with
840 additions
and
407 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.