EuiComboBox keyboard navigation: tab exit (#1576)

* only prevent tab from leaving combobox if the list is open * #1576 changelog entry
elastic · Feb 19, 2019 · 216c12e · 216c12e
1 parent bb9a1ec
commit 216c12e
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 1 deletion.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -6,6 +6,7 @@
 **Bug fixes**
 
 - Fixed content cut off in `EuiContextMenuPanel` when height changes dynamically ([#1559](https://github.com/elastic/eui/pull/1559))
+- Fixed `EuiComboBox` to allow keyboard tab to exit single selection box ([#1576](https://github.com/elastic/eui/pull/1576))
 
 ## [`7.1.0`](https://github.com/elastic/eui/tree/v7.1.0)
 

diff --git a/src/components/combo_box/combo_box.js b/src/components/combo_box/combo_box.js
@@ -343,7 +343,7 @@ export class EuiComboBox extends Component {
 
       case TAB:
         // Disallow tabbing when the user is navigating the options.
-        if (this.hasActiveOption()) {
+        if (this.hasActiveOption() && this.state.isListOpen) {
           e.preventDefault();
           e.stopPropagation();
         }