Skip to content

Commit

Permalink
[EuiContextMenu] Fixed missing underlines on hover
Browse files Browse the repository at this point in the history
- was broken for `<a>` links but not `<button>`s, doh
  • Loading branch information
cee-chen committed Nov 17, 2023
1 parent 0b799ff commit 17c0dd7
Show file tree
Hide file tree
Showing 2 changed files with 9 additions and 6 deletions.
1 change: 1 addition & 0 deletions changelogs/upcoming/7373.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
**Bug fixes**

- Fixed non-`isPrimary` actions (collapsed within a popover) not showing the action description in a tooltip
- Fixed missing underlines on `EuiContextMenu` link hover

**Deprecations**

Expand Down
14 changes: 8 additions & 6 deletions src/components/context_menu/context_menu_item.styles.ts
Original file line number Diff line number Diff line change
Expand Up @@ -27,13 +27,15 @@ export const euiContextMenuItemStyles = (euiThemeContext: UseEuiTheme) => {
color: ${euiTheme.colors.text};
outline-offset: -${euiTheme.focus.width};
&:enabled:hover,
&:enabled:focus {
text-decoration: underline;
}
&:not(:disabled) {
&:hover,
&:focus {
text-decoration: underline;
}
&:enabled:focus {
background-color: ${euiTheme.focus.backgroundColor};
&:focus {
background-color: ${euiTheme.focus.backgroundColor};
}
}
`,
disabled: css`
Expand Down

0 comments on commit 17c0dd7

Please sign in to comment.