Skip to content

Commit

Permalink
do not limit expandable rows in height
Browse files Browse the repository at this point in the history
In some cases max-height of a sub-row needs to be more than 1000px. I tried setting `max-height: max-content`, but the expansion animation was not smooth, so instead added a two step animation -- to 1000px at 90%, and to `max-content` at 100%.

Fixes #3854
  • Loading branch information
nyurik committed Aug 18, 2020
1 parent faeaabf commit 0a560d5
Showing 1 changed file with 4 additions and 2 deletions.
6 changes: 4 additions & 2 deletions src/components/table/_table.scss
Original file line number Diff line number Diff line change
Expand Up @@ -225,10 +225,12 @@
0% {
max-height: 0;
}

100% {
90% {
max-height: 1000px;
}
100% {
max-height: max-content;
}
}

.euiTableRow-isClickable {
Expand Down

0 comments on commit 0a560d5

Please sign in to comment.