Skip to content

Commit

Permalink
Remove @types/node entirely and let npm figure out the types it needs
Browse files Browse the repository at this point in the history
- one less dependency to keep up to date
  • Loading branch information
cee-chen committed Oct 13, 2023
1 parent 9d5cb93 commit 04e4d16
Show file tree
Hide file tree
Showing 3 changed files with 1 addition and 7 deletions.
1 change: 0 additions & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -141,7 +141,6 @@
"@types/classnames": "^2.3.1",
"@types/enzyme": "^3.10.5",
"@types/jest": "^24.0.6",
"@types/node": "^18.18.1",
"@types/react": "^18.2.14",
"@types/react-dom": "^18.2.6",
"@types/react-is": "^17.0.3",
Expand Down
2 changes: 1 addition & 1 deletion wiki/eui-team-processes/upgrading-node.md
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ There are two parts to upgrading Node:

Find and replace all instances of the old Node version in EUI (e.g., `16.18.1`). This primarily affects:

- Local: Update the `.nvmrc` file, and then update `"@types/node"` in package.json
- Local: primarily just the `.nvmrc` file
- CI: primarily involves the `.ci` folder, `scripts/docker-ci`/`scripts/deploy`, and `package.json`, and any other Docker-related Node settings

### Updating the Docker image version
Expand Down
5 changes: 0 additions & 5 deletions yarn.lock
Original file line number Diff line number Diff line change
Expand Up @@ -5015,11 +5015,6 @@
resolved "https://registry.yarnpkg.com/@types/node/-/node-16.18.36.tgz#0db5d7efc4760d36d0d1d22c85d1a53accd5dc27"
integrity sha512-8egDX8dE50XyXWH6C6PRCNkTP106DuUrvdrednFouDSmCi7IOvrqr0frznfZaHifHH/3aq/7a7v9N4wdXMqhBQ==

"@types/node@^18.18.1":
version "18.18.5"
resolved "https://registry.yarnpkg.com/@types/node/-/node-18.18.5.tgz#afc0fd975df946d6e1add5bbf98264225b212244"
integrity sha512-4slmbtwV59ZxitY4ixUZdy1uRLf9eSIvBWPQxNjhHYWEtn0FryfKpyS2cvADYXTayWdKEIsJengncrVvkI4I6A==

"@types/normalize-package-data@^2.4.0":
version "2.4.0"
resolved "https://registry.yarnpkg.com/@types/normalize-package-data/-/normalize-package-data-2.4.0.tgz#e486d0d97396d79beedd0a6e33f4534ff6b4973e"
Expand Down

0 comments on commit 04e4d16

Please sign in to comment.