This repository has been archived by the owner on Jan 31, 2024. It is now read-only.
[resolver] use webpack-resolver for core logic #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
w33ble
suggested changes
Jun 1, 2017
index.js
Outdated
| pluginPaths: [], | ||
| pluginDirs: [ | ||
| '../kibana/plugins', | ||
| '../kibana/core_plugins', |
There was a problem hiding this comment.
This path is wrong, it's kibana/src/core_plugins
also observe the kibanaPath
recurse up paths until a package.json file with a matching name is found, if pluginName is provided. throw if none is found
spalger
commented
Jun 1, 2017
index.js
Outdated
| const matches = glob.sync(globPattern, globOptions); | ||
| debug(`checking in ${checkPath}, matched ${matches.length}`); | ||
| const getRootPackageDir = (dir) => { | ||
| const pkgFile = pkgUp.sync(dir); |
There was a problem hiding this comment.
Do we really need pkgUp for this? We're basically already doing what it is doing in this function.
There was a problem hiding this comment.
Start at the path and recursively look for package.json files that match the rootPackageName or just exist if there isn't a rootPackageName.
There was a problem hiding this comment.
I suppose you're right, we kinda don't...
spalger
commented
Jun 1, 2017
index.js
Outdated
| }; | ||
|
|
||
| /* | ||
| * Resolves the path to Kibana, either from default setting or config | ||
| */ | ||
| function getKibanaPath(config, file, rootPath) { | ||
| function getKibanaPath(config, rootPath) { |
There was a problem hiding this comment.
Can we rename rootPath to projectRoot?
w33ble
approved these changes
Jun 1, 2017
This was referenced Jun 2, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the custom resolver logic and instead wraps the
eslint-import-resolver-webpackmodule, feeding it a custom configuration so that the resolver behaves like Kibana's internal version of webpack.This also adds three settings:
rootPackageName: the name of the package that should be considered the "root" package, useful for packages like Kibana which contain multiple packages so that a file likesrc/core_plugins/console/index.jsresolves as a child of kibana rather than the console plugin package.pluginPaths: an array of paths to plugin folderspluginDirs: an array of paths (relative to the project root) that contain multiple plugin folders