Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Preserve response headers in ESQL CSV tests #99883

Merged
merged 1 commit into from
Sep 25, 2023
Merged

Preserve response headers in ESQL CSV tests #99883

merged 1 commit into from
Sep 25, 2023

Conversation

dnhatn
Copy link
Member

@dnhatn dnhatn commented Sep 25, 2023 •
edited
Loading

This change is to retrieve response headers within the responding thread since we can't pass them between threads in a blocking fashion.

@dnhatn dnhatn requested a review from bpintea September 25, 2023 18:07
@dnhatn dnhatn marked this pull request as ready for review September 25, 2023 18:07
@elasticsearchmachine elasticsearchmachine added the Team:QL (Deprecated) Meta label for query languages team label Sep 25, 2023
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-ql (Team:QL)

@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/elasticsearch-esql (:Query Languages/ES|QL)

@dnhatn dnhatn added the auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) label Sep 25, 2023
bpintea
bpintea approved these changes Sep 25, 2023
View reviewed changes
Copy link
Contributor

@bpintea bpintea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm, thanks Nhat!

@elasticsearchmachine elasticsearchmachine merged commit 8a05425 into elastic:main Sep 25, 2023
@dnhatn dnhatn deleted the warning-csv branch September 25, 2023 18:36
@dnhatn
Copy link
Member Author

dnhatn commented Sep 26, 2023

@nik9000 @bpintea This PR doesn't resolve the issue completely. I will continue with the investigation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bpintea bpintea bpintea approved these changes

@nik9000 nik9000 nik9000 approved these changes

Assignees
No one assigned
Labels
:Analytics/ES|QL AKA ESQL auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) >non-issue Team:QL (Deprecated) Meta label for query languages team v8.11.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dnhatn @elasticsearchmachine @nik9000 @bpintea