-
Notifications
You must be signed in to change notification settings - Fork 25k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Transform] Ignore "index not found" error when delete_dest_index
flag is set but the dest index doesn't exist
#99738
Merged
przemekwitek
merged 6 commits into
elastic:main
from
przemekwitek:delete_dest_index_noop
Sep 21, 2023
Merged
[Transform] Ignore "index not found" error when delete_dest_index
flag is set but the dest index doesn't exist
#99738
przemekwitek
merged 6 commits into
elastic:main
from
przemekwitek:delete_dest_index_noop
Sep 21, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… is set but the dest index doesn't exist
przemekwitek
force-pushed
the
delete_dest_index_noop
branch
from
September 21, 2023 09:55
9c5cc48
to
49cbf3c
Compare
Pinging @elastic/ml-core (Team:ML) |
Hi @przemekwitek, I've created a changelog YAML for you. |
1 task
droberts195
approved these changes
Sep 21, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
run elasticsearch-ci/bwc |
run elasticsearch-ci/part-3 |
run elasticsearch-ci/part-1 |
run elasticsearch-ci/bwc |
💚 Backport successful
|
przemekwitek
added a commit
to przemekwitek/elasticsearch
that referenced
this pull request
Sep 21, 2023
…lag is set but the dest index doesn't exist (elastic#99738)
walterra
added a commit
to elastic/kibana
that referenced
this pull request
Oct 3, 2023
…elete destination index. (#166797) Part of #166796. Depends on elastic/elasticsearch#99738. Uses the `delete_dest_index` flag instead of ES call to delete destination index in the transforms UI when deleting transforms. The PR also fixes some code related to destination indices for transforms and data frame analytics. A destination index can be just a single string. Before the properly typed transform APIs were available via `estypes`, we accidentally treated destination indices similar to source indices which might also be arrays of indices.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes the "index not found" error ignored when
delete_dest_index
flag is set on the transform deletion request and the destination index does not exist.