Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Transform] Ignore "index not found" error when delete_dest_index flag is set but the dest index doesn't exist #99738

Merged
merged 6 commits into from
Sep 21, 2023

Conversation

przemekwitek
Copy link
Contributor

This PR makes the "index not found" error ignored when delete_dest_index flag is set on the transform deletion request and the destination index does not exist.

@przemekwitek przemekwitek marked this pull request as ready for review September 21, 2023 09:56
@przemekwitek przemekwitek added >bug :ml/Transform Transform and removed WIP labels Sep 21, 2023
@elasticsearchmachine elasticsearchmachine added the Team:ML Meta label for the ML team label Sep 21, 2023
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/ml-core (Team:ML)

@elasticsearchmachine
Copy link
Collaborator

Hi @przemekwitek, I've created a changelog YAML for you.

Copy link
Contributor

@droberts195 droberts195 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@przemekwitek
Copy link
Contributor Author

run elasticsearch-ci/bwc

@przemekwitek
Copy link
Contributor Author

run elasticsearch-ci/part-3

@przemekwitek
Copy link
Contributor Author

run elasticsearch-ci/part-1

@przemekwitek
Copy link
Contributor Author

run elasticsearch-ci/bwc

@elasticsearchmachine
Copy link
Collaborator

💚 Backport successful

Status Branch Result
8.10

przemekwitek added a commit to przemekwitek/elasticsearch that referenced this pull request Sep 21, 2023
elasticsearchmachine pushed a commit that referenced this pull request Sep 21, 2023
walterra added a commit to elastic/kibana that referenced this pull request Oct 3, 2023
…elete destination index. (#166797)

Part of #166796.
Depends on elastic/elasticsearch#99738.

Uses the `delete_dest_index` flag instead of ES call to delete
destination index in the transforms UI when deleting transforms.

The PR also fixes some code related to destination indices for
transforms and data frame analytics. A destination index can be just a
single string. Before the properly typed transform APIs were available
via `estypes`, we accidentally treated destination indices similar to
source indices which might also be arrays of indices.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
>bug :ml/Transform Transform Team:ML Meta label for the ML team v8.10.3 v8.11.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants