Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run SignificanceLookup BackgroundFrequency query in its own IndexSearcher #99704

Merged
merged 2 commits into from
Sep 20, 2023

Conversation

iverase
Copy link
Contributor

@iverase iverase commented Sep 20, 2023

Use a brand new index searcher so the query runs on the current thread. Label as non-issue as this is due to an unreleased change.

fixes #99690

@iverase iverase requested a review from martijnvg September 20, 2023 12:10
@elasticsearchmachine elasticsearchmachine added the Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) label Sep 20, 2023
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-analytics-geo (Team:Analytics)

Copy link
Member

@martijnvg martijnvg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@iverase iverase merged commit d279791 into elastic:main Sep 20, 2023
@iverase iverase deleted the SignificanceLookup branch September 20, 2023 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Analytics/Aggregations Aggregations >non-issue Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) v8.11.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CI] SignificantTermsSignificanceScoreIT testScriptScore failing
3 participants