Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mute tests that need to wait for the logs template #99701

Merged
merged 2 commits into from
Sep 20, 2023
Merged

Mute tests that need to wait for the logs template #99701

merged 2 commits into from
Sep 20, 2023

Conversation

gmarouli
Copy link
Contributor

@gmarouli gmarouli commented Sep 20, 2023 •
edited
Loading

Both tests require the logs template to be available. Some times the logs template is not initialised when the test starts and it fails. Since in yaml tests we do not have the possibility to wait, we will convert these tests to rest tests. Until then we will mute them.

Relates to: #97795, #98163

@gmarouli gmarouli added :Data Management/Indices APIs APIs to create and manage indices and templates >test-mute Use for PR that only mute tests labels Sep 20, 2023
@elasticsearchmachine elasticsearchmachine added Team:Data Management Meta label for data/management team v8.11.0 labels Sep 20, 2023
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-data-management (Team:Data Management)

@gmarouli gmarouli requested a review from andreidan September 20, 2023 11:38
andreidan
andreidan approved these changes Sep 20, 2023
View reviewed changes
Copy link
Contributor

@andreidan andreidan left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Mary.

Shall we use the documented pattern to mute? (i.e. all instead of numeric version)

  - skip:
      version: all
      reason: https://github.com/elastic/elasticsearch/issues/97795

@gmarouli
Copy link
Contributor Author

Shall we use the documented pattern to mute? (i.e. all instead of numeric version)

  - skip:
      version: all
      reason: https://github.com/elastic/elasticsearch/issues/97795

Definitely, I forgot about it.

@gmarouli gmarouli merged commit 606dd82 into elastic:main Sep 20, 2023
@gmarouli gmarouli deleted the mute-test-need-to-wait-logs branch December 10, 2024 07:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andreidan andreidan andreidan approved these changes

Assignees
No one assigned
Labels
:Data Management/Indices APIs APIs to create and manage indices and templates Team:Data Management Meta label for data/management team >test-mute Use for PR that only mute tests v8.11.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gmarouli @elasticsearchmachine @andreidan