Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exclude x-pack docs from CI jobs #99207

Merged
merged 2 commits into from
Sep 6, 2023
Merged

Exclude x-pack docs from CI jobs #99207

merged 2 commits into from
Sep 6, 2023

Conversation

jrodewig
Copy link
Contributor

@jrodewig jrodewig commented Sep 5, 2023

Problem:
We currently trigger several unneeded CI checks on PRs that only update docs in x-pack/docs/. Example: #99205

Solution:
Update CI jobs that exclude docs/ to also exclude x-pack/docs/.

Note: In the long-term, we should probably move docs in the x-pack directory into docs. I'll handle that in a separate effort/PR.

@jrodewig jrodewig added :Delivery/Build Build or test infrastructure Team:Delivery Meta label for Delivery team v8.11.0 v8.10.1 v8.9.3 v7.17.14 labels Sep 5, 2023
@jrodewig jrodewig requested a review from a team September 5, 2023 19:51
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-delivery (Team:Delivery)

@jrodewig
Copy link
Contributor Author

jrodewig commented Sep 6, 2023

@elasticsearchmachine update branch

Copy link
Contributor

@mark-vieira mark-vieira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@brianseeders we'll want to do something similar in our Buildkite pipelines once we wire up PR triggers.

@jrodewig jrodewig merged commit 595e69f into elastic:main Sep 6, 2023
@jrodewig jrodewig deleted the exclude-x-pack-docs-from-ci branch September 6, 2023 16:20
@jrodewig
Copy link
Contributor Author

jrodewig commented Sep 6, 2023

💔 Some backports could not be created

Status Branch Result
8.10
8.9
7.17 Could not create pull request: Validation Failed: {"resource":"PullRequest","code":"custom","message":"No commits between elastic:7.17 and jrodewig:backport/7.17/pr-99207"}

Manual backport

To create the backport manually run:

backport --pr 99207

Questions ?

Please refer to the Backport tool documentation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Delivery/Build Build or test infrastructure >non-issue Team:Delivery Meta label for Delivery team v8.9.3 v8.10.0 v8.11.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants