Execute aggregations in its own thread in AggregatorTestCase #99149
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iverase
added
>test
|
Documentation preview: |
|
Pinging @elastic/es-analytics-geo (Team:Analytics) |
elasticsearchmachine
added
Team:Search
|
Pinging @elastic/es-search (Team:Search) |
|
Not needed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #98204, the way queries are executed changed. From now one there are two threadpools, one that coordinates the searches and another to actually execute them. This change was not reflected in the
AggregatorTestCasewhere everything is done on a single thread.This PR modifies modifies the test to reflect the new execution strategy by introducing an AggregatorCollectorManager that is used to execute aggregations.
Unfortunately test are failing with this change, in particular for Composite and frequent items aggregations. This aggregations are now accessing doc values from different threads, something that lucene is not happy about and complains. I guess there are no Integration tests that is exercising this logic for those aggregations.