Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lock down _ttl field #9914

Merged
merged 1 commit into from
Feb 27, 2015
Merged

Lock down _ttl field #9914

merged 1 commit into from
Feb 27, 2015

Conversation

rjernst
Copy link
Member

@rjernst rjernst commented Feb 27, 2015

While the parser allowed changing field type settings, these would never
have been serialized. So this change simply removes parsing using
parseField. Backcompat will still work if a user uploads old settings
(they just would never have worked anyways, so we continue ignoring
them with 1.x, and 2.x will now error).

see #8143

@jpountz
Copy link
Contributor

jpountz commented Feb 27, 2015

Wow, this kind of problems is a source of terrible bugs since things would work fine on a single node but fail badly as soon as you have several of them since serialization looses information... Thanks for fixing!

LGTM

@s1monw
Copy link
Contributor

s1monw commented Feb 27, 2015

+1

While the parser allowed changing field type settings, these would never
have been serialized.  So this change simply removes parsing using
parseField. Backcompat will still work if a user uploads old settings
(they just would never have worked anyways, so we continue ignoring
them with 1.x, and 2.x will now error).

see elastic#8143
closes elastic#9914
@rjernst rjernst merged commit dd0084d into elastic:master Feb 27, 2015
rjernst added a commit that referenced this pull request Feb 27, 2015
@rjernst rjernst added >breaking v2.0.0-beta1 :Search Foundations/Mapping Index mappings, including merging and defining field types labels Mar 4, 2015
@rjernst rjernst deleted the fix/8143-ttl branch March 24, 2015 02:56
@clintongormley clintongormley changed the title Mappings: Lock down _ttl field Lock down _ttl field Jun 6, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
>breaking :Search Foundations/Mapping Index mappings, including merging and defining field types v2.0.0-beta1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants