Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure indexversion comparison for test parameters works for 8.10 patch releases #99003

Merged
merged 2 commits into from
Aug 30, 2023

Conversation

thecoop
Copy link
Member

@thecoop thecoop commented Aug 29, 2023

When 8.10.2 is released, this check will fail when run on 8.10.1. So just remove this check on the 8.10 branch, it only applies on main

Counterpart to #99004

@thecoop thecoop added >bug >test Issues or PRs that are addressing/adding tests :Delivery/Build Build or test infrastructure :Core/Infra/Core Core issues without another label v8.10.1 labels Aug 29, 2023
@github-actions
Copy link
Contributor

Documentation preview:

@thecoop thecoop changed the base branch from main to 8.10 August 29, 2023 15:58
@elasticsearchmachine elasticsearchmachine added Team:Core/Infra Meta label for core/infra team Team:Delivery Meta label for Delivery team labels Aug 29, 2023
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-core-infra (Team:Core/Infra)

@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-delivery (Team:Delivery)

Copy link
Contributor

@ldematte ldematte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just to double check my understanding: we don't need any assertion (e.g. lessThan(8_11)) because you applied the change to the 8.10 branch, so it's implicit, correct?
If so, LGTM!

@thecoop thecoop requested a review from ldematte August 30, 2023 08:57
Copy link
Contributor

@ldematte ldematte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thecoop thecoop merged commit 5667ffc into elastic:8.10 Aug 30, 2023
@thecoop thecoop deleted the fix-indexversion-comparison branch August 30, 2023 10:28
@JVerwolf JVerwolf added v8.10.0 and removed v8.10.1 labels Aug 31, 2023
rjernst added a commit to rjernst/elasticsearch that referenced this pull request Sep 12, 2023
This commit fixes a missed poison pill for inferring index version. The
changed logic allows inferring to work on 8.10 patches, not just 8.10.0.

see elastic#99003
elasticsearchmachine pushed a commit that referenced this pull request Sep 13, 2023
This commit fixes a missed poison pill for inferring index version. The
changed logic allows inferring to work on 8.10 patches, not just 8.10.0.

see #99003
rjernst added a commit to rjernst/elasticsearch that referenced this pull request Sep 13, 2023
This commit fixes a missed poison pill for inferring index version. The changed logic allows inferring to work on 8.10 patches, not just 8.10.0.

see elastic#99003
elasticsearchmachine pushed a commit that referenced this pull request Sep 13, 2023
This commit fixes a missed poison pill for inferring index version. The changed logic allows inferring to work on 8.10 patches, not just 8.10.0.

see #99003
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
>bug :Core/Infra/Core Core issues without another label :Delivery/Build Build or test infrastructure Team:Core/Infra Meta label for core/infra team Team:Delivery Meta label for Delivery team >test Issues or PRs that are addressing/adding tests v8.10.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants