-
Notifications
You must be signed in to change notification settings - Fork 24.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ensure indexversion comparison for test parameters works for 8.10 patch releases #99003
Conversation
Documentation preview: |
Pinging @elastic/es-core-infra (Team:Core/Infra) |
Pinging @elastic/es-delivery (Team:Delivery) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just to double check my understanding: we don't need any assertion (e.g. lessThan(8_11)) because you applied the change to the 8.10 branch, so it's implicit, correct?
If so, LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This commit fixes a missed poison pill for inferring index version. The changed logic allows inferring to work on 8.10 patches, not just 8.10.0. see elastic#99003
This commit fixes a missed poison pill for inferring index version. The changed logic allows inferring to work on 8.10 patches, not just 8.10.0. see #99003
This commit fixes a missed poison pill for inferring index version. The changed logic allows inferring to work on 8.10 patches, not just 8.10.0. see elastic#99003
When 8.10.2 is released, this check will fail when run on 8.10.1. So just remove this check on the 8.10 branch, it only applies on main
Counterpart to #99004