Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ESQL: LTRIM, RTRIM and fix unicode whitespace #98590

Merged
merged 4 commits into from
Aug 17, 2023

Conversation

nik9000
Copy link
Member

@nik9000 nik9000 commented Aug 17, 2023

Here we add support for the following two ESQL functions:

  • LTRIM: remove leading spaces from a string
  • RTRIM: remove trailing spaces from a string

We also fix an issue with the handling of unicode white spaces. We make use of unicode code points to identify unicode whitespace characters instead of relying on ASCII codes.

Moreover, iterating bytes in a Unicode string needs to consider that some Unicode characters are encoded using multiple bytes.

@github-actions
Copy link
Contributor

Documentation preview:

@elasticsearchmachine elasticsearchmachine added the Team:QL (Deprecated) Meta label for query languages team label Aug 17, 2023
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-ql (Team:QL)

@elasticsearchmachine
Copy link
Collaborator

Hi @nik9000, I've created a changelog YAML for you.

@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/elasticsearch-esql (:Query Languages/ES|QL)

Here we add support for the following two ESQL functions:
* LTRIM: remove leading spaces from a string
* RTRIM: remove trailing spaces from a string

We also fix an issue with the handling of unicode white spaces. We
make use of unicode code points to identify unicode whitespace
characters instead of relying on ASCII codes.

Moreover, iterating bytes in a Unicode string needs to consider
that some Unicode characters are encoded using multiple bytes.
@nik9000
Copy link
Member Author

nik9000 commented Aug 17, 2023

Recreation of #98548 targeting main. It's already been approved.

@nik9000
Copy link
Member Author

nik9000 commented Aug 17, 2023

run elasticsearch-ci/docs

@nik9000 nik9000 added the auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) label Aug 17, 2023
@elasticsearchmachine
Copy link
Collaborator

Hi @nik9000, I've created a changelog YAML for you.

@nik9000
Copy link
Member Author

nik9000 commented Aug 17, 2023

run elasticsearch-ci/example-plugins

@nik9000 nik9000 merged commit a380e8c into elastic:main Aug 17, 2023
@nik9000 nik9000 deleted the ltrim_rtrim2 branch August 17, 2023 15:30
csoulios pushed a commit to csoulios/elasticsearch that referenced this pull request Aug 18, 2023
Here we add support for the following two ESQL functions:
* LTRIM: remove leading spaces from a string
* RTRIM: remove trailing spaces from a string

We also fix an issue with the handling of unicode white spaces. We
make use of unicode code points to identify unicode whitespace
characters instead of relying on ASCII codes.

Moreover, iterating bytes in a Unicode string needs to consider
that some Unicode characters are encoded using multiple bytes.
@nik9000 nik9000 mentioned this pull request Mar 27, 2024
75 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Analytics/ES|QL AKA ESQL auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) >feature Team:QL (Deprecated) Meta label for query languages team v8.11.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants