Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update field-mapping.asciidoc that Epoch format is not supported as dynamic date format #98338

Merged
merged 2 commits into from
Aug 10, 2023

Conversation

kunisen
Copy link
Contributor

@kunisen kunisen commented Aug 10, 2023

Update field-mapping.asciidoc that Epoch format is not supported as dynamic date format per https://github.com/elastic/elasticsearch/blob/main/server/src/main/java/org/elasticsearch/index/mapper/RootObjectMapper.java#L430-L431

if (formatter.toString().startsWith("epoch_")) {
  throw new MapperParsingException("Epoch [" + formatter + "] is not supported as dynamic date format");
}

It's in the code but not documented, and this PR is to document it explicitly.

  • Have you signed the contributor license agreement? yes
  • Have you followed the contributor guidelines? yes
  • If submitting code, have you built your formula locally prior to submission with gradle check?
  • If submitting code, is your pull request against main? Unless there is a good reason otherwise, we prefer pull requests against main and will backport as needed.
  • If submitting code, have you checked that your submission is for an OS and architecture that we support?
  • If you are submitting this code for a class then read our policy for that.

…ynamic date format

Update field-mapping.asciidoc that Epoch format is not supported as dynamic date format
@kunisen kunisen added >docs General docs changes Team:Docs Meta label for docs team labels Aug 10, 2023
@github-actions
Copy link
Contributor

Documentation preview:

@kunisen kunisen changed the title Update field-mapping.asciidoc that Epoch format is not supported as d… Update field-mapping.asciidoc that Epoch format is not supported as dynamic date format Aug 10, 2023
@elasticsearchmachine
Copy link
Collaborator

@kunisen please enable the option "Allow edits and access to secrets by maintainers" on your PR. For more information, see the documentation.

@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-docs (Team:Docs)

@elasticsearchmachine elasticsearchmachine added v8.10.0 external-contributor Pull request authored by a developer outside the Elasticsearch team labels Aug 10, 2023
@kunisen
Copy link
Contributor Author

kunisen commented Aug 10, 2023

cc @bojian-ben-li

Copy link
Contributor

@abdonpijpelink abdonpijpelink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @kunisen ! I've left a suggestion. What do you think?

docs/reference/mapping/dynamic/field-mapping.asciidoc Outdated Show resolved Hide resolved
@kunisen
Copy link
Contributor Author

kunisen commented Aug 10, 2023

Thank you Abdon!! 🙇

@kunisen kunisen merged commit 225503a into main Aug 10, 2023
@kunisen kunisen deleted the kunisen-docpr-add-note branch August 10, 2023 07:44
@elasticsearchmachine
Copy link
Collaborator

💔 Backport failed

You can use sqren/backport to manually backport by running backport --upstream elastic/elasticsearch --pr 98338

@abdonpijpelink
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
8.9

Questions ?

Please refer to the Backport tool documentation

abdonpijpelink pushed a commit to abdonpijpelink/elasticsearch that referenced this pull request Aug 10, 2023
…ynamic date format (elastic#98338)

* Update field-mapping.asciidoc that Epoch format is not supported as dynamic date format

Update field-mapping.asciidoc that Epoch format is not supported as dynamic date format

* Update docs/reference/mapping/dynamic/field-mapping.asciidoc

Co-authored-by: Abdon Pijpelink <[email protected]>

---------

Co-authored-by: Abdon Pijpelink <[email protected]>
(cherry picked from commit 225503a)
elasticsearchmachine pushed a commit that referenced this pull request Aug 10, 2023
…ynamic date format (#98338) (#98340)

* Update field-mapping.asciidoc that Epoch format is not supported as dynamic date format

Update field-mapping.asciidoc that Epoch format is not supported as dynamic date format

* Update docs/reference/mapping/dynamic/field-mapping.asciidoc

Co-authored-by: Abdon Pijpelink <[email protected]>

---------

Co-authored-by: Abdon Pijpelink <[email protected]>
(cherry picked from commit 225503a)

Co-authored-by: Kuni Sen <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
>docs General docs changes external-contributor Pull request authored by a developer outside the Elasticsearch team Team:Docs Meta label for docs team v8.9.1 v8.10.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants