[ML] Add setting to scale the processor count used in the model assignment planner #98296
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidkyle
added
:ml
|
Pinging @elastic/ml-core (Team:ML) |
|
Hi @davidkyle, I've created a changelog YAML for you. |
jonathan-buttner
approved these changes
Aug 8, 2023
| @@ -63,7 +64,7 @@ class TrainedModelAssignmentRebalancer { | |||
| this.deploymentToAdd = Objects.requireNonNull(deploymentToAdd); | |||
| } | |||
|
|
|||
| TrainedModelAssignmentMetadata.Builder rebalance() throws Exception { | |||
| TrainedModelAssignmentMetadata.Builder rebalance(Settings settings) { | |||
There was a problem hiding this comment.
nit: Does it make sense to have Settings be passed in the constructor of TrainedModelAssignmentRebalancer and stored as a member to avoid passing it through a bunch of methods?
💔 Backport failed
You can use sqren/backport to manually backport by running |
davidkyle
added a commit
to davidkyle/elasticsearch
that referenced
this pull request
Aug 8, 2023
…nment planner (elastic#98296) Adds the ml.allocated_processors_scale setting which is used to scale the value of ml.allocated_processors_double. This setting influences the number of model allocations that can fit on a node # Conflicts: # x-pack/plugin/ml/src/main/java/org/elasticsearch/xpack/ml/MachineLearning.java # x-pack/plugin/ml/src/main/java/org/elasticsearch/xpack/ml/autoscaling/MlAutoscalingResourceTracker.java # x-pack/plugin/ml/src/main/java/org/elasticsearch/xpack/ml/utils/MlProcessors.java
elasticsearchmachine
pushed a commit
that referenced
this pull request
Aug 8, 2023
…odel assignment planner (#98299) * [ML] Add setting to scale the processor count used in the model assignment planner (#98296) Adds the ml.allocated_processors_scale setting which is used to scale the value of ml.allocated_processors_double. This setting influences the number of model allocations that can fit on a node # Conflicts: # x-pack/plugin/ml/src/main/java/org/elasticsearch/xpack/ml/MachineLearning.java # x-pack/plugin/ml/src/main/java/org/elasticsearch/xpack/ml/autoscaling/MlAutoscalingResourceTracker.java # x-pack/plugin/ml/src/main/java/org/elasticsearch/xpack/ml/utils/MlProcessors.java * non operator
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the
ml.allocated_processors_scalesetting which is used to scale the value ofml.allocated_processors_doubleThe bulk of the change is passing the
settingsobject to where it is now needed, the only logic change is in MlProcessors.java where the returned processor count is scaled by this setting.