Improve error message for index exclusions when multi-target syntax is used for index exclusion #97866
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
quux00
added
>non-issue
:Search/Search
|
Pinging @elastic/es-search (Team:Search) |
javanna
approved these changes
Jul 25, 2023
| // the caller should have put "GET test*,-test3" | ||
| infe = new IndexNotFoundException( | ||
| "if you intended to exclude this index, ensure that you use wildcards that include it before explicitly excluding it", | ||
| indexExpressions[0] |
There was a problem hiding this comment.
can you a quick unit test for this?
There was a problem hiding this comment.
Fixed. Sorry for the oversight.
…s used for index exclusion
An index can be excluded after using a wildcard that includes it, such as
GET test*,-test3/_search
But if a wildcard is not used, it throws an exception:
GET test1,test2,-test3/_search
"type": "index_not_found_exception",
"reason": "no such index [-test3]"
This commit changes the error message in this case to say:
"type": "index_not_found_exception",
"reason": "no such index [-test3] and if you intended to exclude this index, ensure that you use wildcards that include it before explicitly excluding it"
quux00
force-pushed
the
multi-target-syntax/improve-error-message
branch
from
9a11b11 to
475a6f0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An index can be excluded after using a wildcard that includes it, such as
GET test*,-test3/_searchBut if a wildcard is not used, it throws an exception. For example
GET test1,test2,-test3/_searchresults in:This commit changes the error message in this case to say:
This error message also more closely matches a similar error when trying to exclude a cluster in a
cross-cluster search: #97865