Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove ActionPlugin.getClientActions #97709

Merged

Conversation

original-brownbear
Copy link
Member

This isn't used any longer with the transport client gone.

This isn't used any longer with the transport client gone.
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-core-infra (Team:Core/Infra)

@elasticsearchmachine elasticsearchmachine added v8.10.0 Team:Core/Infra Meta label for core/infra team labels Jul 16, 2023
@original-brownbear
Copy link
Member Author

Jenkins run elasticsearch-ci/part-1

@quux00 quux00 added v8.11.0 and removed v8.10.0 labels Aug 16, 2023
Copy link
Contributor

@williamrandolph williamrandolph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apologies that it took me so long to get around to reviewing this. This method was intended for use in the creation of a TransportClient and not really used anywhere else, and isn't used now. I approve.

@original-brownbear original-brownbear added the auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) label Sep 7, 2023
@original-brownbear
Copy link
Member Author

npnp + thanks @williamrandolph !

@elasticsearchmachine elasticsearchmachine merged commit b321351 into elastic:main Sep 7, 2023
@original-brownbear original-brownbear deleted the remove-client-actions branch September 7, 2023 21:42
@original-brownbear original-brownbear restored the remove-client-actions branch November 8, 2023 22:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) :Core/Infra/Transport API Transport client API >non-issue Team:Core/Infra Meta label for core/infra team v8.11.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants