Fix index refresh interval setting for stateless #96800
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The behavior of the refresh interval setting for fast refresh indices is the same as in stateful. Default is 1 sec. Non fast refresh indices have a default and minimum of 5sec refresh interval. Can be disabled (-1). Relates ES-6244
kingherc
added
>non-issue
:Distributed Indexing/Engine
|
Pinging @elastic/es-distributed (Team:Distributed) |
|
Hi @Tim-Brooks , @henningandersen . Made a PR that sets the refresh interval correctly also for stateless. Unfortunately in order for stateless CI to work (see accompanying PR), I had to remove some explicit settings which to my eyes seemingly just set the default value. I am not certain this is a problem for core (CI passes), but feel free to suggest any additional reviewing we may need to do or any other ways forward (could not think of something simple). |
|
Test failed is #96805 @elasticmachine please run elasticsearch-ci/part-3 |
For realizing whether we are in stateless
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The behavior of the refresh interval setting for fast refresh indices is the same as in stateful. Default is 1 sec.
Non fast refresh indices have a default and minimum of 5sec refresh interval. Can be disabled (-1).
Also add a new allowSearchIdleOptimization() function in Engines that can help disallowing the search idle optimization for scheduled refreshes.
Relates ES-6244