[Profiling] Introduce ILM for K/V indices #96268
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With this commit we add ILM configuration for K/V indices that are used by Elastic Universal Profiling. As K/V indices are rolled over after a certain time there may be more than one K/V index to lookup the data for, which has a negative impact on latency. By taking the fact that K/V data depend on events and we always write "live data" we can use the index creation date to constrain which indices we need to consider.
danielmitterdorfer
added
>enhancement
cloud-deploy
|
One build failed due to #95947. @elasticmachine run elasticsearch-ci/part-3 |
|
@elasticmachine run elasticsearch-ci/docs |
...ck/plugin/core/src/main/resources/org/elasticsearch/xpack/profiler/ilm-policy/profiling.json
Show resolved
Hide resolved
danielmitterdorfer
added
the
:UniversalProfiling/Application
|
Pinging @elastic/profiling (Team:Universal Profiling) |
|
Hi @danielmitterdorfer, I've created a changelog YAML for you. |
|
@elasticmachine merge upstream |
This reverts commit 542fc5e.
gmarouli
requested changes
May 31, 2023
There was a problem hiding this comment.
@danielmitterdorfer thanks for the well structured PR! Main comments are about documentation, if you agree after we add them I want to do another "good" pass because the comments will help me deepen my understanding and hopefully I will be sharper the next time! Thank you!
...ck/plugin/core/src/main/resources/org/elasticsearch/xpack/profiler/ilm-policy/profiling.json
Show resolved
Hide resolved
...ck/plugin/core/src/main/resources/org/elasticsearch/xpack/profiler/ilm-policy/profiling.json
Show resolved
Hide resolved
x-pack/plugin/profiler/src/main/java/org/elasticsearch/xpack/profiler/KvIndexResolver.java
Show resolved
Hide resolved
x-pack/plugin/profiler/src/main/java/org/elasticsearch/xpack/profiler/KvIndexResolver.java
Show resolved
Hide resolved
x-pack/plugin/profiler/src/main/java/org/elasticsearch/xpack/profiler/KvIndexResolver.java
Show resolved
Hide resolved
x-pack/plugin/profiler/src/main/java/org/elasticsearch/xpack/profiler/KvIndexResolver.java
Show resolved
Hide resolved
...ain/resources/org/elasticsearch/xpack/profiler/index-template/profiling-symbols-private.json
Outdated
Show resolved
Hide resolved
...ck/plugin/profiler/src/main/java/org/elasticsearch/xpack/profiler/ProfilingIndexManager.java
Outdated
Show resolved
Hide resolved
gmarouli
reviewed
May 31, 2023
...gin/profiler/src/main/java/org/elasticsearch/xpack/profiler/TransportGetProfilingAction.java
Outdated
Show resolved
Hide resolved
gmarouli
approved these changes
May 31, 2023
|
Many thanks for your review @gmarouli! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this commit we add ILM configuration for K/V indices that are used by Elastic Universal Profiling. As K/V indices are rolled over after a certain time there may be more than one K/V index to lookup the data for, which has a negative impact on latency. By taking the fact that K/V data depend on events and we always write "live data" we can use the index creation date to constrain which indices we need to consider.