Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ML] Reenable model upgrade tests after pipeline parsing fix #96193

Closed
wants to merge 1 commit into from
Closed
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
@@ -113,20 +113,10 @@ public void testTrainedModelDeployment() throws Exception {
request.addParameter("timeout", "70s");
}));

// Workaround for an upgrade test failure where an ingest
// pipeline config cannot be parsed by older nodes:
// https://github.com/elastic/elasticsearch/issues/95766
//
// In version 8.3.1 ml stopped parsing the full ingest
// pipeline configuration so will avoid this problem.
// TODO remove this check once https://github.com/elastic/elasticsearch/issues/95766
// is resolved
if (UPGRADE_FROM_VERSION.onOrAfter(Version.V_8_3_1)) {
waitForDeploymentStarted(modelId);
// attempt inference on new and old nodes multiple times
for (int i = 0; i < 10; i++) {
assertInfer(modelId);
}
waitForDeploymentStarted(modelId);
// attempt inference on new and old nodes multiple times
for (int i = 0; i < 10; i++) {
assertInfer(modelId);
}
}
case UPGRADED -> {
Original file line number Diff line number Diff line change
@@ -75,18 +75,8 @@ public void testTrainedModelInference() throws Exception {
}));
List<String> modelIds = getTrainedModels();

// Workaround for an upgrade test failure where an ingest
// pipeline config cannot be parsed by older nodes:
// https://github.com/elastic/elasticsearch/issues/95766
//
// In version 8.3.1 ml stopped parsing the full ingest
// pipeline configuration so will avoid this problem.
// TODO remove this check once https://github.com/elastic/elasticsearch/issues/95766
// is resolved
if (UPGRADE_FROM_VERSION.onOrAfter(Version.V_8_3_1)) {
// Test that stats are serializable and can be gathered
getTrainedModelStats();
}
// Test that stats are serializable and can be gathered
getTrainedModelStats();
// Verify that the pipelines still work and inference is possible
testInfer(modelIds);
}