Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Behavioral Analytics] Temporary remove GeoIP Processor from pipeline #96159

Merged
merged 1 commit into from
May 16, 2023
Merged

[Behavioral Analytics] Temporary remove GeoIP Processor from pipeline #96159

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 0 additions & 7 deletions ...g/elasticsearch/xpack/entsearch/analytics/behavioral_analytics-events-final_pipeline.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,13 +57,6 @@
"ignore_missing": true
}
},
{
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@eyalkoren May I ask a few questions? This pipeline is now managed by the IndexTemplate registry

  • do I need to increase the REGISTRY_VERSION for this change?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally speaking- yes. As long as you use the same pipeline ID, I believe it won't be upgraded if it is already installed otherwise.
In your specific case, maybe it is not required (and even not preferred), because the geoip DB has already been downloaded, so you might as well keep using its processor...

I guess you need to decide whether you enforce proper version maintenance (and increase the version) or make an exception in this case (not increase the version- then only new clusters will use this form).
I hope this makes sense...

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the answer! Yep as this is only a temporary change and will have a further change before 8.9 release, I will keep the version number the same.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So if your further change restores the pipeline state to be the same as it was before, this is indeed not required.
However, if after all your pipeline (or any other component installed through your registry) changes, then version should be increased, otherwise it won't be upgraded in rolling upgrades.

"geoip": {
"field": "session.ip",
"target_field": "session.location",
"ignore_missing": true
}
},
{
"remove": {
"field": "session.ip",
Expand Down