[Behavioral Analytics] Analytics pipeline to the index template registry #96104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joemcelroy
added
:EnterpriseSearch/Application
jimczi
reviewed
May 15, 2023
There was a problem hiding this comment.
Thanks @joemcelroy ! The change looks good. The AnalyticsTemplateRegistryTests need some changes too, are you looking at it too?
Yep! Looks like down to the unexpected pipeline put call to install the declared BA pipeline. Will address it now |
jimczi
approved these changes
May 15, 2023
Added one test to validate that the ingest pipeline is installed but agree could be better coverage added. Will them after this PR later on this week. |
|
Pinging @elastic/ent-search-eng (Team:Enterprise Search) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the changes added in #95782, we are now able to declare and install the behavioral analytics pipeline required by the behavioral analytics Index template.
This PR unblocks behavioral analytics + we can enable the YAML tests which was blocked as the index template could not be installed. The reason is the above PR change only allows index templates that have a pipeline, can be installed if the referring pipeline has been installed.
This impacts where the pipeline now eagerly installed (before was lazily installed https://github.com/elastic/elasticsearch/pull/95775/files) and therefore the geoip processor we depend on will eagerly load the geoip database, increasing the storage footprint of elasticsearch for all customers. See more information here https://github.com/elastic/elasticsearch-benchmarks/issues/1498#issuecomment-1525499333
We will address this optimisation in a future PR.