-
Notifications
You must be signed in to change notification settings - Fork 24.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Logs+] Default pipeline for logs data streams #95971
[Logs+] Default pipeline for logs data streams #95971
Conversation
Pinging @elastic/es-data-management (Team:Data Management) |
Hi @eyalkoren, I've created a changelog YAML for you. |
…pipelines are added
…nto default-timestamp-for-logs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Other than the requested changes to avoid a mustache script evaluation, LGTM
x-pack/plugin/core/src/main/resources/logs-default-pipeline.json
Outdated
Show resolved
Hide resolved
...eams/src/yamlRestTest/resources/rest-api-spec/test/data_stream/220_logs_default_pipeline.yml
Outdated
Show resolved
Hide resolved
@jbaiera Please verify that my fix for |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
"set": { | ||
"description": "If '@timestamp' is missing, set it with the ingest timestamp", | ||
"field": "@timestamp", | ||
"override": false, | ||
"copy_from": "_ingest.timestamp" | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@joegallo FYI this is how we're setting a default timestamp. We'll want to have millisecond precision so we're not truncating here. As the @timestamp
field is mapped as a date
, not date_nanos
, we don't need to truncate microseconds and nanoseconds, I think.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A set
w/ copy_from
is very fast. 👍 and ❤️
"pipeline" : { | ||
"name": "logs@custom", | ||
"ignore_missing_pipeline": true, | ||
"description": "A custom pipeline for logs data streams, which does not exist by default" | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@joshdover @kpollich FYI: the logs-*-*
index template will contain this default logs pipeline that calls out a missing logs@custom
extension point.
x-pack/plugin/core/src/main/resources/logs-default-pipeline.json
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Co-authored-by: James Baiera <[email protected]>
Closes #95551
Closes #95537