Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Logs+] Default pipeline for logs data streams #95971

Merged
merged 20 commits into from
May 12, 2023

Conversation

eyalkoren
Copy link
Contributor

Closes #95551
Closes #95537

@eyalkoren eyalkoren requested review from jbaiera and felixbarny May 10, 2023 04:46
@eyalkoren eyalkoren self-assigned this May 10, 2023
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-data-management (Team:Data Management)

@elasticsearchmachine elasticsearchmachine added Team:Data Management Meta label for data/management team external-contributor Pull request authored by a developer outside the Elasticsearch team labels May 10, 2023
@elasticsearchmachine
Copy link
Collaborator

Hi @eyalkoren, I've created a changelog YAML for you.

Copy link
Member

@felixbarny felixbarny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than the requested changes to avoid a mustache script evaluation, LGTM

@eyalkoren
Copy link
Contributor Author

eyalkoren commented May 10, 2023

@jbaiera Please verify that my fix for CoreWithSecurityClientYamlTestSuiteIT doesn't have unwanted side effects.

@eyalkoren eyalkoren requested a review from felixbarny May 10, 2023 08:46
Copy link
Member

@felixbarny felixbarny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Comment on lines +4 to +9
"set": {
"description": "If '@timestamp' is missing, set it with the ingest timestamp",
"field": "@timestamp",
"override": false,
"copy_from": "_ingest.timestamp"
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@joegallo FYI this is how we're setting a default timestamp. We'll want to have millisecond precision so we're not truncating here. As the @timestamp field is mapped as a date, not date_nanos, we don't need to truncate microseconds and nanoseconds, I think.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A set w/ copy_from is very fast. 👍 and ❤️

Comment on lines 12 to 16
"pipeline" : {
"name": "logs@custom",
"ignore_missing_pipeline": true,
"description": "A custom pipeline for logs data streams, which does not exist by default"
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@joshdover @kpollich FYI: the logs-*-* index template will contain this default logs pipeline that calls out a missing logs@custom extension point.

Copy link
Member

@jbaiera jbaiera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Data Management/Data streams Data streams and their lifecycles >enhancement external-contributor Pull request authored by a developer outside the Elasticsearch team Team:Data Management Meta label for data/management team v8.9.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Logs+] Assign a default @timestamp if missing [Logs+] Make default logs-*-* pipeline customizable
5 participants