[ML] Fix upgrade test assertion #95748
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidkyle
added
>test
|
Pinging @elastic/ml-core (Team:ML) |
droberts195
approved these changes
May 2, 2023
There was a problem hiding this comment.
LGTM, but it would be good to include the explanation from the PR description about why the test is asserting what it's now asserting in a comment in the test itself. The code in the test no longer matches the name of the test method, so it would be good to explain why within the code itself rather than forcing a future reader to look up this PR to find out why.
|
@elasticmachine update branch |
💚 Backport successful
|
elasticsearchmachine
pushed a commit
that referenced
this pull request
May 3, 2023
…95779) The failure was in an assertion that the trained model metadata has been renamed trained_model_allocation -> trained_model_assignment but this can only happen if there is a cluster change event after all nodes have been upgraded. Relaxes the assertion to account for this case.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The failure described in #95501 is reproducible when run in isolation and is likely to fail depending where the deployment is running after before the last node is upgraded.
The failure was in an assertion that the trained model metadata has been renamed
trained_model_allocation->trained_model_assignmentbut this can only happen if there is a cluster change event after all nodes have been upgraded. Other activity in test suite usually ensures that this happens but after #95360 was muted the test started to fail. The fix is to relax the assertion.Closes #95501