Return a copy of messages in MockMTAppender #94982
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pxsalehi
added
>test
elasticsearchmachine
added
v8.8.0
Team:Distributed (Obsolete)
|
Pinging @elastic/es-distributed (Team:Distributed) |
idegtiarenko
reviewed
Apr 3, 2023
server/src/test/java/org/elasticsearch/index/engine/InternalEngineTests.java
Outdated
Show resolved
Hide resolved
idegtiarenko
approved these changes
Apr 3, 2023
|
Thanks, Ievgen! |
pxsalehi
added
auto-merge-without-approval
|
unrelated failure. opened #94987 |
|
@elasticmachine update branch |
|
@elasticmachine run elasticsearch-ci/bwc |
💔 Backport failedThe backport operation could not be completed due to the following error: You can use sqren/backport to manually backport by running |
pxsalehi
added a commit
to pxsalehi/elasticsearch
that referenced
this pull request
Apr 4, 2023
Couldn't reproduce the failure, but in principle there is an issue there. Other options are a CopyOnWriteArrayList or just synchronizing on `messages()` return value. Returning a copy should be enough, since this is only used in one place for asserting some test expectations in an `assertBusy`. Closes elastic#94559
elasticsearchmachine
pushed a commit
that referenced
this pull request
Apr 4, 2023
Couldn't reproduce the failure, but in principle there is an issue there. Other options are a CopyOnWriteArrayList or just synchronizing on `messages()` return value. Returning a copy should be enough, since this is only used in one place for asserting some test expectations in an `assertBusy`. Closes #94559
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Couldn't reproduce the failure, but in principle there is an issue there. Other options are a CopyOnWriteArrayList or just synchronizing on
messages()return value. Returning a copy should be enough, since this is only used in one place for asserting some test expectations in anassertBusy.Closes #94559