Small tidy-up in TaskCancellationService #92795
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We use a fixed-size `CountDownActionListener` here to wait for each of 3 actions to complete, but two of the three actions cannot fail and the result completes a `StepListener` so we can just use a `RefCountingRunnable` instead. Also we can just use `StepListener#addListener` a little further down instead of passing the same runnable in two different arguments.
DaveCTurner
added
:Distributed Coordination/Task Management
elasticsearchmachine
added
the
Team:Distributed (Obsolete)
|
Pinging @elastic/es-distributed (Team:Distributed) |
danielmitterdorfer
pushed a commit
to danielmitterdorfer/elasticsearch
that referenced
this pull request
Jan 12, 2023
We use a fixed-size `CountDownActionListener` here to wait for each of 3 actions to complete, but two of the three actions cannot fail and the result completes a `StepListener` so we can just use a `RefCountingRunnable` instead. Also we can just use `StepListener#addListener` a little further down instead of passing the same runnable in two different arguments.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We use a fixed-size
CountDownActionListenerhere to wait for each of 3 actions to complete, but two of the three actions cannot fail and the result completes aStepListenerso we can just use aRefCountingRunnableinstead.Also we can just use
StepListener#addListenera little further down instead of passing the same runnable in two different arguments.