Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ML] Fix hang if renormalization is retrying writes during feature reset #92524

Merged
merged 1 commit into from
Dec 22, 2022
Merged

[ML] Fix hang if renormalization is retrying writes during feature reset #92524

merged 1 commit into from
Dec 22, 2022

Conversation

droberts195
Copy link
Contributor

This is basically a test issue, as feature reset isn't usable in production due to reseting security.

Fixes #92521

@droberts195
[ML] Fix hang if renormalization is retrying writes during feature reset
e6006ba 
This is basically a test issue, as feature reset isn't usable in production
due to reseting security.

Fixes elastic#92521
@droberts195 droberts195 added >test Issues or PRs that are addressing/adding tests :ml Machine learning v8.7.0 labels Dec 22, 2022
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/ml-core (Team:ML)

@elasticsearchmachine elasticsearchmachine added the Team:ML Meta label for the ML team label Dec 22, 2022
dimitris-athanasiou
dimitris-athanasiou approved these changes Dec 22, 2022
View reviewed changes
Copy link
Contributor

@dimitris-athanasiou dimitris-athanasiou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@droberts195 droberts195 merged commit 08515ea into elastic:main Dec 22, 2022
@droberts195 droberts195 deleted the avoid_hang_on_reset_during_renormalization branch December 22, 2022 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dimitris-athanasiou dimitris-athanasiou dimitris-athanasiou approved these changes

Assignees
No one assigned
Labels
:ml Machine learning Team:ML Meta label for the ML team >test Issues or PRs that are addressing/adding tests v8.7.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[CI] DatafeedJobsIT testStartDatafeed_GivenTimeout_Returns408 failing
3 participants
@droberts195 @elasticsearchmachine @dimitris-athanasiou