[HealthAPI] Add support for the FEATURE_STATE affected resource #92296
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `shards_availability` indicator diagnoses the condition where indices need to be restored from snapshot. Starting with 8.0 using feature_states when restoring from snapshot is mandatory. This adds support for the `FEATURE_STATE` affected resource to aid with building up the snapshot restore API call (which will need to include all the indices and feature states reported by the restore-from-snapshot diagnosis). Note that the health API will not report any indices that are part of a feature state.
(cherry picked from commit 81d41eb17be41b6d128e25fa76db720b241cb72c) Signed-off-by: Andrei Dan <[email protected]>
|
Documentation preview: |
elasticsearchmachine
added
the
Team:Data Management
|
Hi @andreidan, I've created a changelog YAML for you. |
|
Pinging @elastic/es-data-management (Team:Data Management) |
andreidan
commented
Dec 12, 2022
Comment on lines
+214
to
+217
| NOTE: If any <<feature-state,feature states>> need to be restored we'll need to specify them using the | ||
| `feature_states` field and the indices that belong to the feature states we restore must not be specified under `indices`. | ||
| The <<health-api, Health API>> returns both the `indices` and `feature_states` that need to be restored for the restore from snapshot diagnosis. e.g.: | ||
| + |
There was a problem hiding this comment.
It's rather unfortunate we can't recommend something better here because there currently is no way of getting the system indices/data streams associated with a feature state ( #86307 )
|
@elasticmachine update branch |
dakrone
approved these changes
Dec 12, 2022
...a/org/elasticsearch/cluster/routing/allocation/ShardsAvailabilityHealthIndicatorService.java
Outdated
Show resolved
Hide resolved
| * identified unassigned indices and returns the affected {@link Diagnosis.Resource}s of type `INDEX` | ||
| * and if applicable `FEATURE_STATE` | ||
| */ | ||
| private static List<Diagnosis.Resource> getRestoreFromSnapshotAffectedResources( |
There was a problem hiding this comment.
I think we could make this non-private and unit test this pretty easily right? Could you add some tests for that? (It's a complex enough method that I want to make sure we don't break it in the future)
|
@elasticmachine update branch |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The shards_availability indicator diagnoses the condition where indices need to be restored from snapshot.
Starting with 8.0 using feature_states when restoring from snapshot is mandatory.
This adds support for the FEATURE_STATE affected resource to aid with building up the snapshot restore API call (which will need to include all the indices and feature states reported by the restore-from-snapshot diagnosis).
Note that the health API will not report any indices that are part of a feature state.
Closes #91353