-
Notifications
You must be signed in to change notification settings - Fork 25k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added documentation for cartesian-bounds aggregation #91623
Merged
craigtaverner
merged 2 commits into
elastic:main
from
craigtaverner:cartesian_bounds_docs
Nov 18, 2022
Merged
Added documentation for cartesian-bounds aggregation #91623
craigtaverner
merged 2 commits into
elastic:main
from
craigtaverner:cartesian_bounds_docs
Nov 18, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
craigtaverner
added
>docs
General docs changes
:Analytics/Geo
Indexing, search aggregations of geo points and shapes
Team:Docs
Meta label for docs team
v8.6.0
labels
Nov 16, 2022
Documentation preview: |
elasticsearchmachine
added
v8.7.0
Team:Analytics
Meta label for analytical engine team (ESQL/Aggs/Geo)
labels
Nov 16, 2022
Pinging @elastic/es-analytics-geo (Team:Analytics) |
Pinging @elastic/es-docs (Team:Docs) |
craigtaverner
force-pushed
the
cartesian_bounds_docs
branch
from
November 16, 2022 16:12
65ab3c5
to
9d5f951
Compare
kilfoyle
approved these changes
Nov 17, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 🚗
We should push this into main
and backport into 8.6
. I can do the rebase for you if you like.
craigtaverner
force-pushed
the
cartesian_bounds_docs
branch
from
November 18, 2022 09:46
9d5f951
to
5f17f81
Compare
craigtaverner
added a commit
to craigtaverner/elasticsearch
that referenced
this pull request
Nov 18, 2022
* Added documentation for cartesian-bounds aggregation * Fixed rounding errors in docs tests
elasticsearchmachine
pushed a commit
that referenced
this pull request
Nov 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
:Analytics/Geo
Indexing, search aggregations of geo points and shapes
>docs
General docs changes
Team:Analytics
Meta label for analytical engine team (ESQL/Aggs/Geo)
Team:Docs
Meta label for docs team
v8.6.0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The feature itself was added in #91289 and specified in #90157
Since the feature was merged before feature freeze for 8.6.0, the docs need to be reviewed and merged in reasonable time.