[Transform] Fix failure when resolving indices from CCS #91622
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elasticsearchmachine
added
the
needs:triage
hendrikmuhs
added
:ml/Transform
|
Hi @hendrikmuhs, I've created a changelog YAML for you. |
|
Pinging @elastic/ml-core (Team:ML) |
|
@elasticmachine update branch please |
droberts195
reviewed
Nov 17, 2022
There was a problem hiding this comment.
Am I right that every new test is checking the case of the same index name on both local and remote clusters?
I think it would be nice if one of them tested the case of the same index name on multiple remote clusters but no duplicate on the local cluster. Maybe a unit test for this would be the easiest.
|
I added a unit test for 3 remotes with same name indices |
hendrikmuhs
pushed a commit
to hendrikmuhs/elasticsearch
that referenced
this pull request
Nov 18, 2022
properly prefix remote indices in checkpoints, fixes a failure when more than 1 cluster is used and index names clash relates elastic#80984 fixes elastic#91550
hendrikmuhs
pushed a commit
to hendrikmuhs/elasticsearch
that referenced
this pull request
Nov 18, 2022
properly prefix remote indices in checkpoints, fixes a failure when more than 1 cluster is used and index names clash relates elastic#80984 fixes elastic#91550
elasticsearchmachine
pushed a commit
that referenced
this pull request
Nov 18, 2022
elasticsearchmachine
pushed a commit
that referenced
this pull request
Nov 18, 2022
craigtaverner
added a commit
to craigtaverner/elasticsearch
that referenced
this pull request
Nov 21, 2022
craigtaverner
added a commit
that referenced
this pull request
Nov 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
properly prefix remote indices in checkpoints, fixes a failure when more than 1 cluster is used and index names clash
relates #80984
fixes #91550