Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Explain disk headroom settings more in docs #90763

Merged
merged 1 commit into from
Oct 20, 2022
Merged

Explain disk headroom settings more in docs #90763

merged 1 commit into from
Oct 20, 2022

Conversation

kingherc
Copy link
Contributor

Relates to #81406

@kingherc kingherc self-assigned this Oct 10, 2022
@github-actions
Copy link
Contributor

Documentation preview:

@kingherc kingherc added :Distributed Coordination/Allocation All issues relating to the decision making around placing a shard (both master logic & on the nodes) Team:Distributed (Obsolete) Meta label for distributed team (obsolete). Replaced by Distributed Indexing/Coordination. auto-backport-and-merge v8.5.1 >docs General docs changes labels Oct 10, 2022
@kingherc kingherc marked this pull request as ready for review October 10, 2022 13:31
@elasticsearchmachine elasticsearchmachine added the Team:Docs Meta label for docs team label Oct 10, 2022
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-docs (Team:Docs)

@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-distributed (Team:Distributed)

@kingherc
Copy link
Contributor Author

Reminder for reviews

repantis
repantis approved these changes Oct 18, 2022
View reviewed changes
Copy link

@repantis repantis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for this clarification, @kingherc, and apologies for the delayed review.

@kingherc
Copy link
Contributor Author

Thanks! I'll wait a couple of days for any additional feedback from @henningandersen , else I think I can merge this with one approval.

@kingherc
Copy link
Contributor Author

Merging. Can do another PR if there are future comments.

@kingherc kingherc merged commit 0f4374f into elastic:main Oct 20, 2022
@kingherc kingherc deleted the docs/81406-explain-headrooms branch October 20, 2022 15:45
@kingherc kingherc mentioned this pull request Oct 20, 2022
Merged
kingherc added a commit to kingherc/elasticsearch that referenced this pull request Oct 20, 2022
@kingherc
Explain disk headroom settings more in docs (elastic#90763)
1e22107 
Relates to elastic#81406
@elasticsearchmachine
Copy link
Collaborator

💚 Backport successful

Status Branch Result
✅ 8.5

elasticsearchmachine pushed a commit that referenced this pull request Oct 20, 2022
@kingherc
Explain disk headroom settings more in docs (#90763) (#91053)
4e2c7ff 
Relates to #81406
@csoulios csoulios added v8.5.0 and removed v8.5.1 labels Nov 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@repantis repantis repantis approved these changes

@henningandersen henningandersen Awaiting requested review from henningandersen

Assignees

@kingherc kingherc

Labels
:Distributed Coordination/Allocation All issues relating to the decision making around placing a shard (both master logic & on the nodes) >docs General docs changes Team:Distributed (Obsolete) Meta label for distributed team (obsolete). Replaced by Distributed Indexing/Coordination. Team:Docs Meta label for docs team v8.5.0 v8.6.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kingherc @elasticsearchmachine @repantis @csoulios