Check object depth limit at parse time #90285
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elasticsearchmachine
added
v8.6.0
needs:triage
ywelsch
added
>non-issue
:Search Foundations/Mapping
|
Pinging @elastic/es-search (Team:Search) |
romseygeek
approved these changes
Sep 23, 2022
It trips this check (while it does not trip the field limit layer when the mapping is validated on the master. I'm not sure why though.). Not sure if this is a dealbreaker or not. @javanna thoughts? EDIT: found out why this does not trigger on the master (there we only check objectmappers). Still, the problem remains that we can't detect in |
|
OK, figured it out now, pushing a fix. |
romseygeek
approved these changes
Sep 23, 2022
server/src/main/java/org/elasticsearch/index/mapper/MappingLookup.java
Outdated
Show resolved
Hide resolved
|
Thanks @romseygeek! |
mayya-sharipova
added a commit
to mayya-sharipova/elasticsearch
that referenced
this pull request
May 1, 2023
Parsing a hugely nested mapping can lead to stack overflow errors. This PR introduces a protection against this by tracking the depth level while parsing a object in the mapping, and throwing an error if the max depth level is exceeded. Currently we do have a protection against super deep object introduced in elastic#90285. But this protection is happening during dynamic mapping update, when the mapping is already parsed. To avoid stack overflow during parsing, we need this change as well. Closes elastic#52098
mayya-sharipova
added a commit
that referenced
this pull request
May 24, 2023
Parsing a hugely nested mapping can lead to stack overflow errors. This PR introduces a protection against this by tracking the depth level while parsing a object in the mapping, and throwing an error if the max depth level is exceeded. To do this, we use a new mappingParserContext object to parse every new mapping, and not reuse the same mappingParserContext. Currently we do have a protection against super deep object introduced in #90285. But this protection is happening during dynamic mapping update, when the mapping is already parsed. To avoid stack overflow during parsing, we need this change as well. Closes #52098
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Helps avoiding stack overflow errors when the total field limit is set too high.
Relates #87926