Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove ImmutableOpenMap from some server tests #89864

Merged
merged 2 commits into from
Sep 8, 2022
Merged

Remove ImmutableOpenMap from some server tests #89864

merged 2 commits into from
Sep 8, 2022

Conversation

thecoop
Copy link
Member

@thecoop thecoop commented Sep 7, 2022

Remote ImmutableOpenMap from some classes in server tests

@thecoop thecoop requested a review from ChrisHegarty September 7, 2022 11:24
@thecoop thecoop force-pushed the immutablemap-server-tests branch from ac49461 to 86aa35d Compare September 7, 2022 11:36
@thecoop thecoop force-pushed the immutablemap-server-tests branch from 86aa35d to b6169c5 Compare September 7, 2022 12:35
@thecoop thecoop marked this pull request as ready for review September 7, 2022 13:15
@elasticsearchmachine elasticsearchmachine added the needs:triage Requires assignment of a team area label label Sep 7, 2022
@thecoop
Copy link
Member Author

thecoop commented Sep 7, 2022

Part of #86239

@thecoop thecoop added Team:Core/Infra Meta label for core/infra team and removed needs:triage Requires assignment of a team area label labels Sep 7, 2022
@elasticsearchmachine elasticsearchmachine added needs:triage Requires assignment of a team area label and removed Team:Core/Infra Meta label for core/infra team labels Sep 7, 2022
@thecoop thecoop added >refactoring Team:Core/Infra Meta label for core/infra team and removed needs:triage Requires assignment of a team area label labels Sep 7, 2022
@elasticsearchmachine elasticsearchmachine added needs:triage Requires assignment of a team area label and removed Team:Core/Infra Meta label for core/infra team labels Sep 7, 2022
@thecoop thecoop added the :Core/Infra/Core Core issues without another label label Sep 7, 2022
@elasticsearchmachine elasticsearchmachine added the Team:Core/Infra Meta label for core/infra team label Sep 7, 2022
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-core-infra (Team:Core/Infra)

@elasticsearchmachine elasticsearchmachine removed the needs:triage Requires assignment of a team area label label Sep 7, 2022
@thecoop thecoop added needs:triage Requires assignment of a team area label and removed needs:triage Requires assignment of a team area label labels Sep 7, 2022
ChrisHegarty
ChrisHegarty approved these changes Sep 7, 2022
View reviewed changes
Copy link
Contributor

@ChrisHegarty ChrisHegarty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

grcevski
grcevski approved these changes Sep 7, 2022
View reviewed changes
Copy link
Contributor

@grcevski grcevski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for iterating on this!

@thecoop thecoop merged commit 6807b69 into elastic:main Sep 8, 2022
@thecoop thecoop deleted the immutablemap-server-tests branch September 8, 2022 08:54
@thecoop thecoop mentioned this pull request Sep 9, 2022
Open
35 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChrisHegarty ChrisHegarty ChrisHegarty approved these changes

@grcevski grcevski grcevski approved these changes

Assignees
No one assigned
Labels
:Core/Infra/Core Core issues without another label >refactoring Team:Core/Infra Meta label for core/infra team v8.5.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@thecoop @elasticsearchmachine @grcevski @ChrisHegarty