Fix test create and restore searchable snapshot #89745
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
idegtiarenko
added
:Distributed Coordination/Snapshot/Restore
idegtiarenko
commented
Aug 31, 2022
| ); | ||
| assertTrue("Translog doesn't exist", translogExists); | ||
| assertThat("Translog should exist", translogExists, is(true)); |
There was a problem hiding this comment.
Above rewords assertions messages to remove negation
idegtiarenko
commented
Aug 31, 2022
| @@ -254,7 +255,7 @@ public void testCreateAndRestoreSearchableSnapshot() throws Exception { | |||
| assertSearchableSnapshotStats(restoredIndexName, cacheEnabled, nonCachedExtensions); | |||
|
|
|||
| ensureGreen(restoredIndexName); | |||
| assertBusy(() -> assertShardFolders(restoredIndexName, true)); | |||
| assertBusy(() -> assertShardFolders(restoredIndexName, true), 30, TimeUnit.SECONDS); | |||
There was a problem hiding this comment.
This is consistent with another change: #84942
There was a problem hiding this comment.
It looks like this reproduces only if we close the index (eg index files are kept on the disk) and we reuse the same index name for the mounted index. This is likely resulting in files not cleaned in time.
|
Pinging @elastic/es-distributed (Team:Distributed) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to: #89687