-
Notifications
You must be signed in to change notification settings - Fork 25k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Auto-generate preview links for DOC PRs #89670
Conversation
Pinging @elastic/es-docs (Team:Docs) |
You might consider adding a path filter so that a comment is only added to PRs that change docs. I haven't done this myself, but it might look something like this: on:
pull_request_target:
types: [opened]
paths:
- 'docs/*'
- 'add_other_doc_dirs_here' Or even better, target asciidoc files: on:
pull_request_target:
types: [opened]
paths:
- '**.asciidoc' I think. Again, I haven't tested this. |
Ah, yes, good point! Targeting asciidoc files seems like the ticket. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM @debadair 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚢
Excited to see this in action! |
Adds a GitHub Action that will automatically create preview links when a doc pull request is created. Links are added in a comment on the PR.
Borrowed from @richkuz -- Thanks!