-
Notifications
You must be signed in to change notification settings - Fork 25k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update changelog (release highlight) for #89106 #89649
Update changelog (release highlight) for #89106 #89649
Conversation
Pinging @elastic/es-docs (Team:Docs) |
Pinging @elastic/es-ql (Team:QL) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
of a single document is particularly high (eg. queries that involve script evaluation) | ||
and in queries with a small LIMIT value. | ||
In our tests, on some specific queries, we see a speed-up of more than 50%, | ||
with peaks of ~95% (from 600ms to 20ms). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think specific timing values tend to not age well (and prompt questions about the setup), but if we do this generally, it's all good (an alternative being just "dramatic performance improvements" etc.).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I was in doubt about that too. I took inspiration from existing changelog for v 8.4, so I guess it's fine
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like the wording, which says "our tests" and "specific queries" to set expectations correctly, so that users do not assume that it would necesseraly mean the same for their queries.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm
Adding highlight section to the changelog of the PR about SQL track_total_hits, since
release highlight
label was added after the PR was already merged.