Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update changelog (release highlight) for #89106 #89649

Merged

Conversation

luigidellaquila
Copy link
Contributor

@luigidellaquila luigidellaquila commented Aug 26, 2022

Adding highlight section to the changelog of the PR about SQL track_total_hits, since release highlight label was added after the PR was already merged.

@luigidellaquila luigidellaquila added >docs General docs changes :Analytics/SQL SQL querying and removed v8.5.0 labels Aug 26, 2022
@luigidellaquila luigidellaquila marked this pull request as ready for review August 26, 2022 11:50
@elasticsearchmachine elasticsearchmachine added the Team:Docs Meta label for docs team label Aug 26, 2022
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-docs (Team:Docs)

@elasticsearchmachine elasticsearchmachine added the Team:QL (Deprecated) Meta label for query languages team label Aug 26, 2022
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-ql (Team:QL)

Copy link
Contributor

@jpountz jpountz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Copy link
Contributor

@astefan astefan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

of a single document is particularly high (eg. queries that involve script evaluation)
and in queries with a small LIMIT value.
In our tests, on some specific queries, we see a speed-up of more than 50%,
with peaks of ~95% (from 600ms to 20ms).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think specific timing values tend to not age well (and prompt questions about the setup), but if we do this generally, it's all good (an alternative being just "dramatic performance improvements" etc.).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I was in doubt about that too. I took inspiration from existing changelog for v 8.4, so I guess it's fine

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the wording, which says "our tests" and "specific queries" to set expectations correctly, so that users do not assume that it would necesseraly mean the same for their queries.

Copy link
Contributor

@bpintea bpintea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@luigidellaquila luigidellaquila merged commit afefcbc into elastic:main Aug 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Analytics/SQL SQL querying >docs General docs changes Team:Docs Meta label for docs team Team:QL (Deprecated) Meta label for query languages team v8.5.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants