[ML] Return 408 when start deployment api times out #89612
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Pinging @elastic/ml-core (Team:ML) |
|
Hi @dimitris-athanasiou, I've created a changelog YAML for you. |
|
Hi @dimitris-athanasiou, I've updated the changelog YAML for you. |
dimitris-athanasiou
force-pushed
the
timeout-on-start-deployment-should-be-400
branch
from
55fa8f5 to
b9c23f6
Compare
This commit changes the status code returned when the start trained model deployment api times out from `500` to `408`. In addition, we add validation that the timeout must be positive. Relates elastic#89585
dimitris-athanasiou
force-pushed
the
timeout-on-start-deployment-should-be-400
branch
from
b9c23f6 to
84e0aed
Compare
|
Hi @dimitris-athanasiou, I've created a changelog YAML for you. |
|
Hi @dimitris-athanasiou, I've updated the changelog YAML for you. |
|
@elasticmachine update branch |
dimitris-athanasiou
deleted the
timeout-on-start-deployment-should-be-400
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit changes the status code returned when the start
trained model deployment api times out from
500to408.In addition, we add validation that the timeout must be positive.
Relates #89585