Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Small cleanup in ShardGetService #89578

Merged
merged 1 commit into from
Aug 24, 2022
Merged

Small cleanup in ShardGetService #89578

merged 1 commit into from
Aug 24, 2022

Conversation

romseygeek
Copy link
Contributor

We can use try-with-resources here, and remove a null check because IndexShard.get
never returns null.

@romseygeek romseygeek added >non-issue :Search/Search Search-related issues that do not fall into other categories v8.5.0 labels Aug 24, 2022
@romseygeek romseygeek requested a review from nik9000 August 24, 2022 14:09
@romseygeek romseygeek self-assigned this Aug 24, 2022
@elasticsearchmachine elasticsearchmachine added the Team:Search Meta label for search team label Aug 24, 2022
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-search (Team:Search)

@romseygeek
Copy link
Contributor Author

I was in here anyway and thought I'd pull this tiny refactoring out into its own PR.

@romseygeek romseygeek merged commit 5422860 into elastic:main Aug 24, 2022
@romseygeek romseygeek deleted the get/cleanup branch August 24, 2022 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nik9000 nik9000 nik9000 approved these changes

Assignees

@romseygeek romseygeek

Labels
>non-issue :Search/Search Search-related issues that do not fall into other categories Team:Search Meta label for search team v8.5.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@romseygeek @elasticsearchmachine @nik9000