Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable ML when testing old ES versions on newer GLIBC #89517

Merged
merged 1 commit into from
Aug 22, 2022

Conversation

mark-vieira
Copy link
Contributor

When testing on systems with later GLIBC versions (> 2.34) we need to ensure we disable ML for ES versions that have not been patched with this fix. This PR updates the old repository integration tests appropriately.

Example failure: https://gradle-enterprise.elastic.co/s/do3qaak77usde

@mark-vieira mark-vieira added >test Issues or PRs that are addressing/adding tests :Delivery/Build Build or test infrastructure auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) auto-backport-and-merge v8.3.4 v8.4.1 labels Aug 22, 2022
@elasticsearchmachine elasticsearchmachine added v8.5.0 Team:Delivery Meta label for Delivery team labels Aug 22, 2022
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-delivery (Team:Delivery)

@mark-vieira
Copy link
Contributor Author

@elasticmachine run elasticsearch-ci/part-1

@elasticsearchmachine elasticsearchmachine merged commit dc0cfd9 into elastic:main Aug 22, 2022
@mark-vieira mark-vieira deleted the ml_old_es_fix branch August 22, 2022 20:06
mark-vieira added a commit to mark-vieira/elasticsearch that referenced this pull request Aug 22, 2022
When testing on systems with later GLIBC versions (> 2.34) we need to
ensure we disable ML for ES versions that have not been patched with
this fix. This PR updates the old repository integration tests
appropriately.

Example failure: https://gradle-enterprise.elastic.co/s/do3qaak77usde
mark-vieira added a commit to mark-vieira/elasticsearch that referenced this pull request Aug 22, 2022
When testing on systems with later GLIBC versions (> 2.34) we need to
ensure we disable ML for ES versions that have not been patched with
this fix. This PR updates the old repository integration tests
appropriately.

Example failure: https://gradle-enterprise.elastic.co/s/do3qaak77usde
@elasticsearchmachine
Copy link
Collaborator

💚 Backport successful

Status Branch Result
8.3
8.4

elasticsearchmachine pushed a commit that referenced this pull request Aug 22, 2022
When testing on systems with later GLIBC versions (> 2.34) we need to
ensure we disable ML for ES versions that have not been patched with
this fix. This PR updates the old repository integration tests
appropriately.

Example failure: https://gradle-enterprise.elastic.co/s/do3qaak77usde
elasticsearchmachine pushed a commit that referenced this pull request Aug 22, 2022
When testing on systems with later GLIBC versions (> 2.34) we need to
ensure we disable ML for ES versions that have not been patched with
this fix. This PR updates the old repository integration tests
appropriately.

Example failure: https://gradle-enterprise.elastic.co/s/do3qaak77usde
elasticsearchmachine pushed a commit that referenced this pull request Aug 24, 2022
Follow up to #89517 to ensure we don't mistakenly pass the
`xpack.ml.enabled` flag on versions of ES that have no such setting.
mark-vieira added a commit to mark-vieira/elasticsearch that referenced this pull request Aug 24, 2022
Follow up to elastic#89517 to ensure we don't mistakenly pass the
`xpack.ml.enabled` flag on versions of ES that have no such setting.
mark-vieira added a commit to mark-vieira/elasticsearch that referenced this pull request Aug 24, 2022
Follow up to elastic#89517 to ensure we don't mistakenly pass the
`xpack.ml.enabled` flag on versions of ES that have no such setting.
elasticsearchmachine pushed a commit that referenced this pull request Aug 24, 2022
Follow up to #89517 to ensure we don't mistakenly pass the
`xpack.ml.enabled` flag on versions of ES that have no such setting.

Co-authored-by: Elastic Machine <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) :Delivery/Build Build or test infrastructure Team:Delivery Meta label for Delivery team >test Issues or PRs that are addressing/adding tests v8.3.4 v8.4.1 v8.5.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants