Small cleanups to Allocation Performance #89378
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Two fixes: 1. Looking up `Custom` values over and over for every shard incurs a measurable cost. This removes that cost for desired nodes and node shutdown metadata. 2. Node shutdown metadata logic wasn't inlining nicely because of the wrapped map. No need to be as complicated as we were in many spots, use a simple immutable map for all operations and remove a bunch of branching.
original-brownbear
added
>non-issue
:Distributed Coordination/Allocation
elasticsearchmachine
added
the
Team:Distributed (Obsolete)
|
Pinging @elastic/es-distributed (Team:Distributed) |
| return Optional.ofNullable((NodesShutdownMetadata) this.custom(NodesShutdownMetadata.TYPE)) | ||
| .map(NodesShutdownMetadata::getAllNodeMetadataMap) | ||
| .orElse(Collections.emptyMap()); | ||
| return this.custom(NodesShutdownMetadata.TYPE, NodesShutdownMetadata.EMPTY).getAllNodeMetadataMap(); |
There was a problem hiding this comment.
This is way simpler 👍
| private final Map<String, SingleNodeShutdownMetadata> nodeShutdowns; | ||
|
|
||
| @Nullable | ||
| private final DesiredNodes desiredNodes; |
There was a problem hiding this comment.
Do we need above to make it inline?
There was a problem hiding this comment.
This isn't really about inlining. This is just faster outright because we don't have to lookup from the customs map for every shard.
idegtiarenko
approved these changes
Aug 16, 2022
|
Thanks Ievgen! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two fixes:
Customvalues over and over for every shard incurs a measurable cost.This removes that cost for desired nodes and node shutdown metadata.
No need to be as complicated as we were in many spots, use a simple immutable map
for all operations and remove a bunch of branching.
relates #77466