Add source fallback support for unsigned long mapped type #89349
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jdconrad
added
>enhancement
:Search Foundations/Mapping
|
Pinging @elastic/es-search (Team:Search) |
|
Hi @jdconrad, I've created a changelog YAML for you. |
romseygeek
reviewed
Aug 16, 2022
|
|
||
| import static org.elasticsearch.search.DocValueFormat.MASK_2_63; | ||
|
|
||
| public class SourceValueFetcherSortedUnsignedLongIndexFieldData extends SourceValueFetcherIndexFieldData<SortedNumericDocValues> { |
There was a problem hiding this comment.
Can we have some javadoc here?
| @Override | ||
| public boolean advanceExact(int doc) throws IOException { | ||
| sourceLookup.setSegmentAndDocument(leafReaderContext, doc); | ||
| values = new ArrayList<>(); |
There was a problem hiding this comment.
Do we need to create a new list every time here or can we reuse an existing one?
There was a problem hiding this comment.
Changed this to clear as suggested. Good catch.
|
@romseygeek Thank you the first review. I've updated the PR based on your feedback. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds source fallback support for unsigned long by adding a new
SourceValueFetcherSortedUnsignedLongIndexFieldDatasimilar to the other numeric types.